rpm2archive: - is only supported as lone argument

Give an error message otherwise.

Resolves: rpm-software-management#3923

Author: ffesti

tests/rpmgeneral.at

@@ -457,6 +457,13 @@ runroot rpm2archive "${RPMTEST}"/data/SRPMS/hello-1.0-1.src.rpm | tar tzf -
 [./hello-1.0.tar.gz
 ./hello.spec
 ])
+RPMTEST_CHECK([
+runroot rpm2archive "${RPMTEST}"/data/SRPMS/hello-1.0-1.src.rpm -
+],
+[1],
+[],
+[No other arguments allowed beside of -
+])
 
 RPMTEST_CLEANUP
 

tools/rpm2archive.cc

@@ -287,6 +287,8 @@ int main(int argc, char *argv[])
     int rc = 0;
     poptContext optCon;
     const char *fn;
+    int arg_stdin = 0;
+    int args = 0;
 
     xsetprogname(argv[0]);	/* Portability call -- see system.h */
     rpmReadConfigFiles(NULL, NULL);
@@ -324,6 +326,18 @@ int main(int argc, char *argv[])
 	    goto exit;
     }
 
+    /* Make sure - is given as a lone argument */
+    for (const char ** arg = poptGetArgs(optCon); *arg; arg++){
+	if (!strcmp(*arg, "-"))
+	    arg_stdin = 1;
+	args++;
+    }
+    if (arg_stdin && args > 1) {
+	fprintf(stderr, "No other arguments allowed beside of -\n");
+	rc = 1;
+	goto exit;
+    }
+
     while ((fn = poptGetArg(optCon)) != NULL) {
 	rc = process_package(ts, fn);
 	if (rc != 0)