Store Sources (and Patches) as they are declared

Append new Source/Patch entries at the end of the list instead of the
front. This will also put them into the header in the order they are
declared. This change does not put them in order of their numbers or have
Sources and Patch separated out.

Resolves: rpm-software-management#3014

Author: ffesti

build/parsePreamble.cc

@@ -137,6 +137,7 @@ static inline int parseYesNo(const char * s)
 static struct Source *newSource(uint32_t num, const char *path, int flags)
 {
     struct Source *p = new Source {};
+    p->next = NULL;
     p->num = num;
     p->fullSource = xstrdup(path);
     p->flags = flags;
@@ -320,10 +321,16 @@ int addSource(rpmSpec spec, int specline, const char *srcname, rpmTagVal tag)
 	return RPMRC_FAIL;
     }
 
-    /* Create the entry and link it in */
+    /* Create the entry and link it at the end */
     p = newSource(num, srcname, flag);
-    p->next = spec->sources;
-    spec->sources = p;
+    if (!spec->sources) {
+	spec->sources = p;
+    } else {
+	Source * s = spec->sources;
+	while (s->next)
+	    s = s->next;
+	s->next = p;
+    }
     spec->numSources++;
 
     rasprintf(&buf, "%s%d",

tests/rpmbuild.at

@@ -3021,8 +3021,8 @@ runroot rpmbuild \
 ],
 [1],
 [],
-[error: Bad file: /notthere/hello-1.0-modernize.patch: No such file or directory
-error: Bad file: /notthere/hello-1.0.tar.gz: No such file or directory
+[error: Bad file: /notthere/hello-1.0.tar.gz: No such file or directory
+error: Bad file: /notthere/hello-1.0-modernize.patch: No such file or directory
 ])
 RPMTEST_CLEANUP
 

tests/rpmpython.at

@@ -76,8 +76,8 @@ for pkg in spec.packages:
     print(pkg.header.format('%{nvr}'))
 print(spec.sourceHeader.format('%{nvr}'))
 ],
-[src hello-1.0-modernize.patch 0 2
-src hello-1.0.tar.gz 0 1
+[src hello-1.0.tar.gz 0 1
+src hello-1.0-modernize.patch 0 2
 hello-1.0-1
 hello-1.0-1
 ])