refactor: Remove unused error variables

Author: ffflorian

packages/electron-info/src/HTTPService.test.ts

@@ -28,7 +28,7 @@ describe('HTTPService', () => {
       try {
         await httpService.downloadReleasesFile(mockUrl, '');
         assert.fail('Should throw on timeout');
-      } catch (_error) {}
+      } catch {}
     });
   });
 });

packages/gh-open/src/RepositoryService.ts

@@ -79,7 +79,7 @@ export class RepositoryService {
       gitHead = await fsAsync.readFile(gitHeadFile, 'utf-8');
       gitHead = gitHead.trim();
       this.logger.info('Read git head file', {gitHead});
-    } catch (_error) {
+    } catch {
       const errorMessage = `Could not find git HEAD file in "${gitDir}".`;
       throw new Error(errorMessage);
     }
@@ -103,7 +103,7 @@ export class RepositoryService {
       gitConfig = await fsAsync.readFile(gitConfigFile, 'utf-8');
       gitConfig = gitConfig.trim();
       this.logger.info('Read git config file', {gitConfigFile});
-    } catch (_error) {
+    } catch {
       const errorMessage = `Could not find git config file: "${gitConfigFile}"`;
       throw new Error(errorMessage);
     }

packages/jszip-cli/src/FileService.ts

@@ -22,11 +22,11 @@ export class FileService {
       try {
         await fs.access(dirPath, fs.constants.W_OK);
         return true;
-      } catch (_error) {
+      } catch {
         this.logger.info(`Directory "${dirPath}" exists but is not writable.`);
         return false;
       }
-    } catch (_error) {
+    } catch {
       this.logger.info(`Directory "${dirPath}" doesn't exist.`, this.options.force ? 'Creating.' : 'Not creating.');
       if (this.options.force) {
         await fs.ensureDir(dirPath);
@@ -42,7 +42,7 @@ export class FileService {
       try {
         await fs.access(filePath, fs.constants.F_OK | fs.constants.R_OK);
         return true;
-      } catch (_error) {
+      } catch {
         return false;
       }
     }
@@ -60,7 +60,7 @@ export class FileService {
           this.options.force ? 'Forcing overwrite.' : 'Not overwriting.'
         );
         return this.options.force;
-      } catch (_error) {
+      } catch {
         return true;
       }
     }

packages/mock-udp/src/index.test.ts

@@ -40,7 +40,7 @@ describe('mock-udp.clean', () => {
       try {
         client.send(buffer, 0, buffer.length, 1000 + index, 'localhost');
         assert.fail();
-      } catch (_error) {}
+      } catch {}
     });
   });
 });
@@ -115,7 +115,7 @@ describe('mock-udp.overriddenSocketSend', () => {
         try {
           client.send(buffer, 0, buffer.length, 1000, 'localhost');
           assert.fail();
-        } catch (_error) {
+        } catch {
           done(void 0);
         }
       });
@@ -128,7 +128,7 @@ describe('mock-udp.overriddenSocketSend', () => {
     try {
       client.send(buffer, buffer.length, buffer.length, 1000, 'localhost');
       assert.fail();
-    } catch (_error) {}
+    } catch {}
     expect(scope.done()).toBe(false);
   });
 
@@ -138,7 +138,7 @@ describe('mock-udp.overriddenSocketSend', () => {
     try {
       client.send(buffer, buffer.length + 1, buffer.length, 1000, 'localhost');
       assert.fail();
-    } catch (_error) {}
+    } catch {}
     expect(scope.done()).toBe(false);
   });
 
@@ -148,7 +148,7 @@ describe('mock-udp.overriddenSocketSend', () => {
     try {
       client.send(buffer, 0, buffer.length + 1, 1000, 'localhost');
       assert.fail();
-    } catch (_error) {}
+    } catch {}
     expect(scope.done()).toBe(false);
   });
 });

packages/my-timezone/src/MyTimezone.ts

@@ -136,7 +136,7 @@ export class MyTimezone {
       try {
         const longitude = parseFloat(parsedRegex.groups.longitude);
         return {longitude};
-      } catch (_error) {
+      } catch {
         throw new Error(`Invalid coordinates: "${coordinates}"`);
       }
     }

packages/publish-flat/src/copyJson.ts

@@ -4,7 +4,7 @@ import fs from 'fs-extra';
 async function checkFile(filePath: string): Promise<void> {
   try {
     await fs.access(filePath, fs.constants.F_OK | fs.constants.R_OK);
-  } catch (_error) {
+  } catch {
     throw new Error(`Input file "${filePath} doesn't exist or is not readable.`);
   }
 }
@@ -32,7 +32,7 @@ export async function copyJson(inputFile: string, outputFile: string, values: st
   if (!newJSONRaw) {
     console.info('New JSON file has no content.');
     newJSONRaw = '{}';
-  } else if (/^\{/.test(newJSONRaw)) {
+  } else if (newJSONRaw.startsWith('{')) {
     const spacesMatch = newJSONRaw.match(/^\{[\n\r]?( *)/);
     if (spacesMatch && spacesMatch[1]) {
       spaces = spacesMatch[1].length;

packages/scrabble-cheater/src/index.test.ts

@@ -24,7 +24,7 @@ describe('ScrabbleCheater', () => {
     try {
       await sc.start();
       assert.fail();
-    } catch (_error) {
+    } catch {
       // nothing to do
     }
   });