feat: Remove fs-extra (#977)

ffflorian · web-flow · commit d1434d970939 · 2025-11-13T14:12:37.000+01:00
diff --git a/packages/electron-icon-generator/package.json b/packages/electron-icon-generator/package.json
@@ -3,13 +3,11 @@
   "bin": "dist/index.js",
   "dependencies": {
     "commander": "14.0.2",
-    "fs-extra": "11.3.2",
     "icon-gen": "5.0.0",
     "jimp": "1.6.0"
   },
   "description": "An icon generator to generate all the icon files needed for electron packaging",
   "devDependencies": {
-    "@types/fs-extra": "11.0.4",
     "@types/pngjs": "6.0.5",
     "rimraf": "6.1.0",
     "tsx": "4.20.6",
diff --git a/packages/electron-icon-generator/src/index.ts b/packages/electron-icon-generator/src/index.ts
@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
+import fs from 'node:fs/promises';
 import path from 'node:path';
-import fs from 'fs-extra';
 import {Jimp} from 'jimp';
 import icongen from 'icon-gen';
 
@@ -36,9 +36,17 @@ export class IconGenerator {
   private async createPNG(size: number): Promise<string> {
     const fileName = size.toString();
 
-    await fs.ensureDir(this.options.output);
-    await fs.ensureDir(this.iconsDir);
-    await fs.ensureDir(this.PNGoutputDir);
+    try {
+      await fs.mkdir(this.options.output, {recursive: true});
+    } catch {}
+
+    try {
+      await fs.mkdir(this.iconsDir, {recursive: true});
+    } catch {}
+
+    try {
+      await fs.mkdir(this.PNGoutputDir, {recursive: true});
+    } catch {}
 
     const image = await Jimp.read(this.options.input);
     const resizeFilePath = path.join(this.PNGoutputDir, fileName);
@@ -62,7 +70,9 @@ export class IconGenerator {
       const macIconsDir = path.join(this.iconsDir, 'mac');
       const winIconsDir = path.join(this.iconsDir, 'win');
 
-      await fs.ensureDir(macIconsDir);
+      try {
+        await fs.mkdir(macIconsDir, {recursive: true});
+      } catch {}
 
       await icongen.default(this.PNGoutputDir, macIconsDir, {
         icns: {
@@ -72,7 +82,9 @@ export class IconGenerator {
         report: !this.options.silent,
       });
 
-      await fs.ensureDir(winIconsDir);
+      try {
+        await fs.mkdir(winIconsDir, {recursive: true});
+      } catch {}
 
       await icongen.default(this.PNGoutputDir, winIconsDir, {
         icns: {
diff --git a/packages/electron-info/package.json b/packages/electron-info/package.json
@@ -12,9 +12,7 @@
   },
   "description": "Get useful data about Electron releases.",
   "devDependencies": {
-    "@types/fs-extra": "11.0.4",
     "@types/semver": "7.7.1",
-    "fs-extra": "11.3.2",
     "http-status-codes": "2.3.0",
     "nock": "14.0.10",
     "rimraf": "6.1.0",
diff --git a/packages/electron-info/src/ElectronInfo.test.ts b/packages/electron-info/src/ElectronInfo.test.ts
@@ -1,9 +1,9 @@
 import path from 'node:path';
 import {randomUUID} from 'node:crypto';
+import fs from 'node:fs/promises';
 import {expect, describe, test, beforeEach, beforeAll, afterAll, afterEach} from 'vitest';
 import {StatusCodes as HTTP_STATUS} from 'http-status-codes';
 import nock from 'nock';
-import fs from 'fs-extra';
 
 import {ElectronInfo, RawReleaseInfo} from './ElectronInfo.js';
 
@@ -30,22 +30,24 @@ const createRandomBody = (): RawReleaseInfo[] => [
 ];
 
 const provideReleaseFile = async () => {
-  await fs.copy(fullReleasesFile, path.join(tempDirDownload, 'latest.json'));
+  await fs.cp(fullReleasesFile, path.join(tempDirDownload, 'latest.json'));
 };
 
 describe('ElectronInfo', () => {
   let releases: string;
 
   beforeAll(async () => {
-    await fs.ensureDir(tempDir);
+    try {
+      await fs.mkdir(tempDir);
+    } catch {}
     releases = await fs.readFile(fullReleasesFile, 'utf8');
   });
 
   beforeEach(() => {
     nock(mockUrl).get('/').reply(HTTP_STATUS.OK, releases);
   });
 
-  afterAll(() => fs.remove(tempDir));
+  afterAll(() => fs.rm(tempDir, {force: true, recursive: true}));
 
   afterEach(() => nock.cleanAll());
 
diff --git a/packages/jszip-cli/package.json b/packages/jszip-cli/package.json
@@ -4,15 +4,13 @@
   "dependencies": {
     "commander": "14.0.2",
     "cosmiconfig": "9.0.0",
-    "fs-extra": "11.3.2",
     "glob": "11.0.3",
     "jszip": "3.10.1",
     "logdown": "3.3.1",
     "progress": "2.0.3"
   },
   "description": "A zip CLI based on jszip.",
   "devDependencies": {
-    "@types/fs-extra": "11.0.4",
     "@types/progress": "2.0.7",
     "cross-env": "10.1.0",
     "rimraf": "6.1.0",
diff --git a/packages/jszip-cli/src/BuildService.test.ts b/packages/jszip-cli/src/BuildService.test.ts
@@ -1,15 +1,15 @@
 import {expect, describe, test, vi, beforeEach, beforeAll} from 'vitest';
-import {JSZipCLI} from '.';
-import type {BuildService} from './BuildService';
+import {JSZipCLI} from './index.js';
+import type {BuildService} from './BuildService.js';
 
 describe('BuildService', () => {
   let jsZipCLI: JSZipCLI;
 
   beforeAll(() => {
-    vi.mock('fs-extra', () => ({
-      default: {
-        lstat: () => Promise.resolve({isDirectory: () => false, isFile: () => true}),
-        readFile: () => {},
+    vi.mock('fs', () => ({
+      promises: {
+        lstat: async () => ({isDirectory: () => false, isFile: () => true}),
+        readFile: async () => {},
       },
     }));
     vi.mock('glob', () => ({
@@ -18,7 +18,7 @@ describe('BuildService', () => {
   });
 
   const addDefaultSpies = (buildService: BuildService) => {
-    vi.spyOn<any, any>(buildService, 'checkOutput').mockReturnValue(() => Promise.resolve());
+    vi.spyOn<any, any>(buildService, 'checkOutput').mockReturnValue(async () => {});
     vi.spyOn<any, any>(buildService, 'addFile');
     vi.spyOn<any, any>(buildService['fileService'], 'writeFile').mockReturnValue(Promise.resolve());
   };
diff --git a/packages/jszip-cli/src/BuildService.ts b/packages/jszip-cli/src/BuildService.ts
@@ -1,5 +1,5 @@
 import path from 'node:path';
-import fs from 'fs-extra';
+import {promises as fs, Stats as fsStats} from 'node:fs';
 import JSZip from 'jszip';
 import logdown from 'logdown';
 import progress from 'progress';
@@ -87,7 +87,7 @@ export class BuildService {
 
   private async addFile(entry: Entry, isLink = false): Promise<void> {
     const {resolvedPath, zipPath} = entry;
-    let fileStat: fs.Stats;
+    let fileStat: fsStats;
     let fileData: Buffer | string;
 
     try {
@@ -139,7 +139,7 @@ export class BuildService {
   }
 
   private async checkEntry(entry: Entry): Promise<void> {
-    let fileStat: fs.Stats;
+    let fileStat: fsStats;
     try {
       fileStat = await fs.lstat(entry.resolvedPath);
     } catch (error) {
diff --git a/packages/jszip-cli/src/ExtractService.ts b/packages/jszip-cli/src/ExtractService.ts
@@ -1,6 +1,6 @@
+import fs from 'node:fs/promises';
 import os from 'node:os';
 import path from 'node:path';
-import fs from 'fs-extra';
 import JSZip from 'jszip';
 import logdown from 'logdown';
 import progress from 'progress';
@@ -37,7 +37,9 @@ export class ExtractService {
     for (const entry of rawEntries) {
       const jszip = new JSZip();
       if (this.outputDir) {
-        await fs.ensureDir(this.outputDir);
+        try {
+          await fs.mkdir(this.outputDir, {recursive: true});
+        } catch {}
       }
 
       const resolvedPath = path.resolve(entry);
@@ -63,9 +65,11 @@ export class ExtractService {
       let index = 0;
 
       for (const [filePath, entry] of entries) {
-        const resolvedFilePath = path.join(this.outputDir!, filePath);
+        const resolvedFilePath = path.join(this.outputDir, filePath);
         if (entry.dir) {
-          await fs.ensureDir(resolvedFilePath);
+          try {
+            await fs.mkdir(resolvedFilePath, {recursive: true});
+          } catch {}
         } else {
           const data = await entry.async('nodebuffer');
           await fs.writeFile(resolvedFilePath, data, {
diff --git a/packages/jszip-cli/src/FileService.ts b/packages/jszip-cli/src/FileService.ts
@@ -1,5 +1,5 @@
+import fs from 'node:fs/promises';
 import path from 'node:path';
-import fs from 'fs-extra';
 import logdown from 'logdown';
 
 import type {TerminalOptions} from './interfaces.js';
@@ -29,7 +29,9 @@ export class FileService {
     } catch {
       this.logger.info(`Directory "${dirPath}" doesn't exist.`, this.options.force ? 'Creating.' : 'Not creating.');
       if (this.options.force) {
-        await fs.ensureDir(dirPath);
+        try {
+          await fs.mkdir(dirPath, {recursive: true});
+        } catch {}
         return true;
       }
       return false;
diff --git a/packages/jszip-cli/src/JSZipCLI.test.ts b/packages/jszip-cli/src/JSZipCLI.test.ts
@@ -1,7 +1,7 @@
+import * as fs from 'node:fs/promises';
 import * as path from 'node:path';
 import {expect, describe, test, vi, beforeAll, afterAll} from 'vitest';
-import fs from 'fs-extra';
-import {ConfigFileOptions, JSZipCLI, TerminalOptions} from '.';
+import {ConfigFileOptions, JSZipCLI, TerminalOptions} from './index.js';
 
 const tempDir = path.resolve(__dirname, '.temp');
 const configFilePath = path.resolve(tempDir, 'config.json');
@@ -28,13 +28,17 @@ async function buildOptions(additionalConfig?: Partial<AllOptions>): Promise<All
     ...additionalConfig,
   };
 
-  await fs.writeJSON(configFilePath, fileConfig);
+  await fs.writeFile(configFilePath, JSON.stringify(fileConfig), 'utf-8');
   return fileConfig;
 }
 
 describe('JSZipCLI', () => {
-  beforeAll(() => fs.ensureDir(tempDir));
-  afterAll(() => fs.remove(tempDir));
+  beforeAll(async () => {
+    try {
+      await fs.mkdir(tempDir);
+    } catch {}
+  });
+  afterAll(() => fs.rm(tempDir, {force: true, recursive: true}));
 
   test('can read from a configuration file', async () => {
     const builtOptions = await buildOptions();
diff --git a/packages/jszip-cli/src/cli.ts b/packages/jszip-cli/src/cli.ts
@@ -1,16 +1,17 @@
 #!/usr/bin/env node
 
+import fs from 'node:fs';
 import path from 'node:path';
 import {program as commander} from 'commander';
-import fs from 'fs-extra';
 
 import {JSZipCLI} from './JSZipCLI.js';
 
 const __dirname = import.meta.dirname;
 const packageJsonPath = path.join(__dirname, '../package.json');
 
-const {description, name, version}: {description: string; name: string; version: string} =
-  fs.readJSONSync(packageJsonPath);
+const {description, name, version}: {description: string; name: string; version: string} = JSON.parse(
+  fs.readFileSync(packageJsonPath, 'utf-8')
+);
 
 interface CLIOptions {
   config?: string;
diff --git a/packages/publish-flat/package.json b/packages/publish-flat/package.json
@@ -8,13 +8,11 @@
     "@npmcli/arborist": "9.1.6",
     "@types/npmcli__arborist": "6.3.1",
     "commander": "14.0.2",
-    "fs-extra": "11.3.2",
     "logdown": "3.3.1",
     "npm-packlist": "10.0.3"
   },
   "description": "Publish your project without the dist directory",
   "devDependencies": {
-    "@types/fs-extra": "11.0.4",
     "@types/npm-packlist": "7.0.3",
     "rimraf": "6.1.0",
     "tsx": "4.20.6",
diff --git a/packages/publish-flat/src/PublishFlat.ts b/packages/publish-flat/src/PublishFlat.ts
@@ -1,8 +1,8 @@
+import fs from 'node:fs/promises';
 import {execFileSync} from 'node:child_process';
 import os from 'node:os';
 import path from 'node:path';
 import Arborist from '@npmcli/arborist';
-import fs from 'fs-extra';
 import logdown from 'logdown';
 import packlist from 'npm-packlist';
 
@@ -80,11 +80,11 @@ export class PublishFlat {
     const outputDir = this.options.outputDir ? path.resolve(this.options.outputDir) : await this.createTempDir();
 
     for (const file of normalFiles) {
-      await fs.copy(path.join(this.packageDir, file), path.join(outputDir, file));
+      await fs.cp(path.join(this.packageDir, file), path.join(outputDir, file));
     }
 
     for (const {fileName, replacedFilename} of filesInFlattenedDir) {
-      await fs.copy(path.join(this.packageDir, fileName), path.join(outputDir, replacedFilename));
+      await fs.cp(path.join(this.packageDir, fileName), path.join(outputDir, replacedFilename));
     }
 
     this.logger.info(`Flattened ${files.length} files in "${outputDir}".`);
@@ -108,7 +108,7 @@ export class PublishFlat {
       this.logger.info(stdout);
     }
 
-    await fs.remove(tempDir);
+    await fs.rm(tempDir, {force: true, recursive: true});
   }
 
   private cleanDirName(dirName: string): string {
@@ -121,7 +121,7 @@ export class PublishFlat {
   }
 
   private async cleanPackageJson(filePath: string, filesInFlattenedDir: FilesInFlattenedDir): Promise<void> {
-    const packageJson: PackageJson = await fs.readJSON(filePath);
+    const packageJson: PackageJson = JSON.parse(await fs.readFile(filePath, 'utf-8'));
 
     if (Array.isArray(packageJson.files)) {
       packageJson.files = packageJson.files
diff --git a/packages/publish-flat/src/copyJson.ts b/packages/publish-flat/src/copyJson.ts
@@ -1,5 +1,5 @@
+import fs from 'node:fs/promises';
 import path from 'node:path';
-import fs from 'fs-extra';
 
 async function checkFile(filePath: string): Promise<void> {
   try {
@@ -22,9 +22,8 @@ export async function copyJson(inputFile: string, outputFile: string, values: st
   const outputResolved = path.resolve(outputFile);
 
   await checkFile(inputResolved);
-  await fs.ensureFile(outputResolved);
 
-  const originalJSON: packageJson = await fs.readJSON(inputResolved);
+  const originalJSON: packageJson = JSON.parse(await fs.readFile(inputResolved, 'utf-8'));
   let newJSONRaw = await fs.readFile(outputResolved, 'utf-8');
 
   let spaces = 2;
@@ -47,5 +46,5 @@ export async function copyJson(inputFile: string, outputFile: string, values: st
     }
   }
 
-  await fs.writeJSON(outputResolved, newJSON, {spaces});
+  await fs.writeFile(outputResolved, JSON.stringify(newJSON, null, spaces));
 }
diff --git a/yarn.lock b/yarn.lock
