Skip to content

Commit aeb4d59

Browse files
committed
chore: ⬆️ update kotlintest and remove junit 4
1 parent 5dc2352 commit aeb4d59

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

app/build.gradle

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,17 @@ dependencies {
7676
implementation libs.rx_android
7777
implementation libs.steho
7878

79-
testImplementation libs.arch_comp_room_test
80-
testImplementation libs.arch_comp_test
79+
testImplementation (libs.arch_comp_room_test) {
80+
exclude module: 'junit'
81+
}
82+
testImplementation (libs.arch_comp_test) {
83+
exclude module: 'junit'
84+
}
8185
testImplementation libs.junit_api
8286
testImplementation libs.kotlintest
83-
testImplementation libs.koin_test
87+
testImplementation (libs.koin_test) {
88+
exclude module: 'junit'
89+
}
8490
testImplementation libs.mockito_kotlin
8591

8692
testRuntimeOnly libs.junit_engine

app/src/main/java/es/ffgiraldez/comicsearch/query/base/ui/QueryActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class QueryActivity : AppCompatActivity() {
2121
override fun onCreate(savedInstanceState: Bundle?) {
2222
super.onCreate(savedInstanceState)
2323
DataBindingUtil.setContentView<QueryActivityBinding>(this, R.layout.query_activity).also {
24-
it.setLifecycleOwner(this@QueryActivity)
24+
it.setLifecycleOwner(this)
2525
it.delegate = QueryScreenDelegate(suggestionViewModel, searchViewModel, QueryVolumeAdapter(), navigator)
2626
}
2727
}

dependencies.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ ext {
4545
koin_architecture : [group: 'org.koin', name: 'koin-android-viewmodel', version: versions.koin],
4646
koin_test : [group: 'org.koin', name: 'koin-test', version: versions.koin],
4747
kotlin_stdlib : [group: 'org.jetbrains.kotlin', name: 'kotlin-stdlib-jdk7', version: versions.kotlin],
48-
kotlintest : [group: 'io.kotlintest', name: 'kotlintest-runner-junit5', version: '3.2.1'],
48+
kotlintest : [group: 'io.kotlintest', name: 'kotlintest-runner-junit5', version: '3.3.0'],
4949
mockito_kotlin : [group: 'com.nhaarman.mockitokotlin2', name: 'mockito-kotlin', version: '2.1.0'],
5050
picasso : [group: 'com.squareup.picasso', name: 'picasso', version: '2.5.2'],
5151
retrofit : [group: 'com.squareup.retrofit2', name: 'retrofit', version: versions.retrofit],

0 commit comments

Comments
 (0)