chore: ♻️ fix naming

Author: ffgiraldez

app/src/main/java/es/ffgiraldez/comicsearch/comics/data/ComicRepository.kt

@@ -18,23 +18,23 @@ abstract class ComicRepository<T> (
 ) {
     fun findByTerm(term: String): Flowable<Either<ComicError, List<T>>> =
             local.findQueryByTerm(term)
-                    .flatMap { findSuggestions(it, term) }
+                    .flatMap { find(it, term) }
 
-    private fun findSuggestions(
+    private fun find(
             query: Option<Query>,
             term: String
     ): Flowable<out Either<ComicError, List<T>>> = when (query) {
-        is None -> searchSuggestions(term)
-        is Some -> fetchSuggestions(query)
+        is None -> search(term)
+        is Some -> fetch(query)
     }
 
-    private fun searchSuggestions(term: String): Flowable<Either<ComicError, List<T>>> =
+    private fun search(term: String): Flowable<Either<ComicError, List<T>>> =
             remote.findByTerm(term)
                     .map { right<ComicError, List<T>>(it) }
                     .onErrorReturn { left<ComicError, List<T>>(NetworkError) }
-                    .flatMapPublisher { saveSuggestions(it, term) }
+                    .flatMapPublisher { save(it, term) }
 
-    private fun saveSuggestions(
+    private fun save(
             results: Either<ComicError, List<T>>,
             term: String
     ): Flowable<Either<ComicError, List<T>>> =
@@ -44,7 +44,7 @@ abstract class ComicRepository<T> (
                 local.insert(term, it).toFlowable<Either<ComicError, List<T>>>()
             })
 
-    private fun fetchSuggestions(it: Some<Query>): Flowable<Either<EmptyResultsError, List<T>>> =
+    private fun fetch(it: Some<Query>): Flowable<Either<EmptyResultsError, List<T>>> =
             local.findByQuery(it.t)
                     .map {
                         when (it.isEmpty()) {

app/src/main/java/es/ffgiraldez/comicsearch/query/base/ui/QueryViewStateExt.kt

@@ -11,6 +11,9 @@ val <T>QueryViewState<T>.error: Option<ComicError>
         else -> Option.empty()
     }
 
+val <T>QueryViewState<T>.hasError: Boolean
+    get() = !error.isEmpty()
+
 val <T>QueryViewState<T>.results: List<T>
     get() = when (this) {
         is QueryViewState.Result -> _results

app/src/main/java/es/ffgiraldez/comicsearch/query/search/ui/SearchBindingAdapters.kt

@@ -6,17 +6,16 @@ import android.widget.ProgressBar
 import android.widget.TextView
 import androidx.databinding.BindingAdapter
 import androidx.recyclerview.widget.RecyclerView
-import arrow.core.Option
 import com.arlib.floatingsearchview.FloatingSearchView
 import com.arlib.floatingsearchview.suggestions.model.SearchSuggestion
-import es.ffgiraldez.comicsearch.comics.domain.ComicError
 import es.ffgiraldez.comicsearch.comics.domain.Volume
 import es.ffgiraldez.comicsearch.platform.gone
 import es.ffgiraldez.comicsearch.query.base.presentation.QueryViewState
 import es.ffgiraldez.comicsearch.query.base.ui.OnVolumeSelectedListener
 import es.ffgiraldez.comicsearch.query.base.ui.QuerySearchSuggestion.ResultSuggestion
 import es.ffgiraldez.comicsearch.query.base.ui.QueryVolumeAdapter
 import es.ffgiraldez.comicsearch.query.base.ui.error
+import es.ffgiraldez.comicsearch.query.base.ui.hasError
 import es.ffgiraldez.comicsearch.query.base.ui.loading
 import es.ffgiraldez.comicsearch.query.base.ui.results
 import es.ffgiraldez.comicsearch.query.base.ui.toHumanResponse
@@ -56,7 +55,7 @@ fun RecyclerView.bindStateData(inputAdapter: QueryVolumeAdapter, data: QueryView
     }
 
     data?.let {
-        bindError(data.error)
+        bindError(data.hasError)
         bindResults(data.results)
     }
 }
@@ -77,8 +76,8 @@ fun ProgressBar.bindProgress(data: QueryViewState<Volume>?) = data?.let { state
     gone(!state.loading)
 }
 
-private fun RecyclerView.bindError(error: Option<ComicError>): Unit =
-        error.fold({ View.VISIBLE }, { View.GONE }).let { this.visibility = it }
+private fun RecyclerView.bindError(error: Boolean): Unit =
+        gone(error)
 
 private fun RecyclerView.bindResults(error: List<Volume>): Unit = with(adapter as QueryVolumeAdapter) {
     this.submitList(error)