Adding State.from_.any() #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #497 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 1566 1593 +27
Branches 249 253 +4
=========================================
+ Hits 1566 1593 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fgmacedo
commented
Nov 17, 2024
|
|
||
| def add_from_attributes(cls, attrs): # noqa: C901 | ||
| for key, value in sorted(attrs.items(), key=lambda pair: pair[0]): | ||
| for key, value in attrs.items(): |
Owner
Author
There was a problem hiding this comment.
The library is pre-python3.7 where the dictionary order was not guaranteed. This order hack is not required since 3.7.
…implifyed unbounded callbacks setup
fgmacedo
force-pushed
the
macedo/from_any
branch
from
a49683e to
5828cbd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #494