[ADT] Refactor DenseSet::insert (NFC) (llvm#157324)

kazutakahirata · web-flow · commit 13647d82eb84 · 2025-09-07T10:39:38.000-07:00
DenseMap::try_emplace can default-construct DenseSetEmptyKey, so we
don't need to pass Empty on our own.
diff --git a/llvm/include/llvm/ADT/DenseSet.h b/llvm/include/llvm/ADT/DenseSet.h
@@ -192,13 +192,11 @@ class DenseSetImpl {
   void erase(const_iterator CI) { return TheMap.erase(CI.I); }
 
   std::pair<iterator, bool> insert(const ValueT &V) {
-    detail::DenseSetEmpty Empty;
-    return TheMap.try_emplace(V, Empty);
+    return TheMap.try_emplace(V);
   }
 
   std::pair<iterator, bool> insert(ValueT &&V) {
-    detail::DenseSetEmpty Empty;
-    return TheMap.try_emplace(std::move(V), Empty);
+    return TheMap.try_emplace(std::move(V));
   }
 
   /// Alternative version of insert that uses a different (and possibly less

Original file line number	Diff line number	Diff line change
`@@ -192,13 +192,11 @@ class DenseSetImpl {`
`192`	`192`	`void erase(const_iterator CI) { return TheMap.erase(CI.I); }`
`193`	`193`
`194`	`194`	`std::pair<iterator, bool> insert(const ValueT &V) {`
`195`		`- detail::DenseSetEmpty Empty;`
`196`		`- return TheMap.try_emplace(V, Empty);`
	`195`	`+ return TheMap.try_emplace(V);`
`197`	`196`	`}`
`198`	`197`
`199`	`198`	`std::pair<iterator, bool> insert(ValueT &&V) {`
`200`		`- detail::DenseSetEmpty Empty;`
`201`		`- return TheMap.try_emplace(std::move(V), Empty);`
	`199`	`+ return TheMap.try_emplace(std::move(V));`
`202`	`200`	`}`
`203`	`201`
`204`	`202`	`/// Alternative version of insert that uses a different (and possibly less`