Skip to content

Conversation

xhyrom
Copy link
Contributor

@xhyrom xhyrom commented Jan 11, 2025

Copy link
Member

@esoadamo esoadamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! One, hopefully small, detail and LGTM.
Can you also please remove whitespace changes, so that the diff is not that big?

@@ -112,6 +112,8 @@ export class DefaultService {
this.configuration = configuration;
this.basePath = basePath || configuration.basePath || this.basePath;
}

this.basePath = this.basePath.replace(/\/+$/, ''); // remove trailing slash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it is impossible for us to modify this file since it is auto generated by npm run gen.api and as such these changes would be overwritten. Maybe this needs to be changed on backend instead?

@xhyrom
Copy link
Contributor Author

xhyrom commented Aug 25, 2025

Looks good, thanks! One, hopefully small, detail and LGTM.
Can you also please remove whitespace changes, so that the diff is not that big?

sure, will work on it today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants