perf: drop fs-extra in favour of native node:fs (#444)

Author: danielroe

package.json

@@ -39,7 +39,6 @@
     "@tsconfig/strictest": "^2.0.5",
     "@types/babel__code-frame": "^7.0.6",
     "@types/debug": "^4.1.12",
-    "@types/fs-extra": "^11.0.1",
     "@types/minimist": "^1.2.2",
     "@types/node": "^16.0.0",
     "@types/prompts": "^2.0.13",
@@ -48,7 +47,6 @@
     "chalk": "^4.1.1",
     "execa": "^5.1.1",
     "fast-json-stable-stringify": "^2.1.0",
-    "fs-extra": "^11.1.0",
     "lint-staged": "^11.0.0",
     "minimist": "^1.2.5",
     "npm-run-all2": "^5.0.0",

packages/vite-plugin-checker/package.json

@@ -41,7 +41,6 @@
     "chalk": "^4.1.1",
     "chokidar": "^3.5.1",
     "commander": "^8.0.0",
-    "fs-extra": "^11.1.0",
     "npm-run-path": "^4.0.1",
     "strip-ansi": "^6.0.0",
     "tiny-invariant": "^1.1.0",
@@ -54,7 +53,6 @@
   "devDependencies": {
     "@biomejs/biome": "^1.8.3",
     "@types/eslint": "^7.29.0",
-    "@types/fs-extra": "^11.0.1",
     "@vue/language-core": "~2.1.6",
     "esbuild": "^0.25.0",
     "meow": "^9.0.0",

packages/vite-plugin-checker/src/checkers/vueTsc/prepareVueTsc.ts

@@ -1,10 +1,8 @@
-import { access, readFile, rm, writeFile } from 'node:fs/promises'
+import { access, cp, mkdir, readFile, rm, writeFile } from 'node:fs/promises'
 import { createRequire } from 'node:module'
 import path, { dirname } from 'node:path'
 import { fileURLToPath } from 'node:url'
-import fsExtra from 'fs-extra'
 
-const { copy, mkdir } = fsExtra
 const _require = createRequire(import.meta.url)
 
 // isomorphic __dirname https://antfu.me/posts/isomorphic-dirname
@@ -54,9 +52,9 @@ export async function prepareVueTsc() {
 
   if (shouldBuildFixture) {
     await rm(targetTsDir, { force: true, recursive: true })
-    await mkdir(targetTsDir)
+    await mkdir(targetTsDir, { recursive: true })
     const sourceTsDir = path.resolve(_require.resolve('typescript'), '../..')
-    await copy(sourceTsDir, targetTsDir)
+    await cp(sourceTsDir, targetTsDir, { recursive: true })
     await writeFile(vueTscFlagFile, proxyApiPath)
 
     // 2. sync modification of lib/tsc.js with vue-tsc

playground/vitestGlobalSetup.ts

@@ -1,4 +1,5 @@
-import fs from 'fs-extra'
+import { rmSync } from 'node:fs'
+import fs from 'node:fs/promises'
 import os from 'node:os'
 import path from 'node:path'
 import { glob } from 'tinyglobby'
@@ -15,15 +16,16 @@ export async function setup(): Promise<void> {
     args: process.env.CI ? ['--no-sandbox', '--disable-setuid-sandbox'] : undefined,
   })
 
-  await fs.mkdirp(DIR)
+  await fs.mkdir(DIR, { recursive: true })
   await fs.writeFile(path.join(DIR, 'wsEndpoint'), browserServer.wsEndpoint())
 
   const tempDir = path.resolve(__dirname, '../playground-temp')
-  await fs.ensureDir(tempDir)
-  await fs.emptyDir(tempDir)
+  await fs.rm(tempDir, { force: true, recursive: true })
+  await fs.mkdir(tempDir, { recursive: true })
   await fs
-    .copy(path.resolve(__dirname, '../playground'), tempDir, {
+    .cp(path.resolve(__dirname, '../playground'), tempDir, {
       dereference: false,
+      recursive: true,
       filter(file) {
         const _file = file.replace(/\\/g, '/')
         return !_file.includes('__tests__') && !file.match(/dist(\/|$)/)
@@ -42,16 +44,16 @@ export async function setup(): Promise<void> {
   if (process.env['VITEST_TEST_CJS']) {
     const packageJsons = await glob(`${tempDir}/**/package.json`)
     for (const packageJson of packageJsons) {
-      const packageJsonContents = await fs.readJson(packageJson)
+      const packageJsonContents = await fs.readFile(packageJson, 'utf-8').then(r => JSON.parse(r.toString()))
       delete packageJsonContents['module']
-      await fs.writeJson(packageJson, packageJsonContents, { spaces: 2 })
+      await fs.writeFile(packageJson, JSON.stringify(packageJsonContents, null, 2))
     }
   }
 }
 
 export async function teardown(): Promise<void> {
   browserServer?.close()
   if (!process.env.VITE_PRESERVE_BUILD_ARTIFACTS) {
-    fs.removeSync(path.resolve(__dirname, '../playground-temp'))
+    rmSync(path.resolve(__dirname, '../playground-temp'), { force: true, recursive: true })
   }
 }

playground/vitestSetup.ts

@@ -1,5 +1,6 @@
 import execa from 'execa'
-import fs from 'fs-extra'
+import fs from 'node:fs/promises'
+import { existsSync } from 'node:fs'
 import type * as http from 'node:http'
 import os from 'node:os'
 import path, { dirname, join, resolve } from 'node:path'
@@ -88,7 +89,7 @@ beforeAll(async (s) => {
     return
   }
 
-  const wsEndpoint = fs.readFileSync(join(DIR, 'wsEndpoint'), 'utf-8')
+  const wsEndpoint = await fs.readFile(join(DIR, 'wsEndpoint'), 'utf-8')
   if (!wsEndpoint) {
     throw new Error('wsEndpoint not found')
   }
@@ -109,12 +110,12 @@ beforeAll(async (s) => {
 
       // when `root` dir is present, use it as vite's root
       const testCustomRoot = resolve(testDir, 'root')
-      rootDir = fs.existsSync(testCustomRoot) ? testCustomRoot : testDir
+      rootDir = existsSync(testCustomRoot) ? testCustomRoot : testDir
 
       const testCustomServe = [
         resolve(dirname(rootDir), 'serve.ts'),
         resolve(dirname(rootDir), 'serve.js'),
-      ].find((i) => fs.existsSync(i))
+      ].find((i) => existsSync(i))
 
       if (testCustomServe && isServe) {
         // test has custom server configuration.
@@ -160,7 +161,7 @@ export async function startDefaultServe({
   const testCustomConfig = resolve(testDir, 'vite.config.js')
 
   let config: InlineConfig | undefined
-  if (fs.existsSync(testCustomConfig)) {
+  if (existsSync(testCustomConfig)) {
     // test has custom server configuration.
     config = await import(testCustomConfig).then((r) => r.default)
   }

pnpm-lock.yaml

@@ -1,20 +1,17 @@
+import fs from 'node:fs/promises'
 import path, { dirname } from 'node:path'
 import { fileURLToPath } from 'node:url'
-import fs from 'fs-extra'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = dirname(__filename)
 
 async function main() {
-  await fs.outputJson(
+  await fs.writeFile(
     path.resolve(
       __dirname,
       '../packages/vite-plugin-checker/dist/cjs/package.json',
     ),
-    { type: 'commonjs' },
-    {
-      spaces: 2,
-    },
+    JSON.stringify({ type: 'commonjs' }, null, 2),
   )
 }
 

scripts/patchCjs.mjs

@@ -1,23 +1,25 @@
+import { rmSync } from 'node:fs'
+import fs from 'node:fs/promises'
 import path from 'node:path'
-import fs from 'fs-extra'
 
 const tempRuntimePath = path.resolve(
   __dirname,
   '../packages/vite-plugin-checker/src/@runtime',
 )
 
 export async function setup(): Promise<void> {
-  await fs.ensureDir(tempRuntimePath)
-  await fs.emptyDir(tempRuntimePath)
-  await fs.copy(
+  await fs.rm(tempRuntimePath, { force: true, recursive: true })
+  await fs.mkdir(tempRuntimePath, { recursive: true })
+  await fs.cp(
     path.resolve(__dirname, '../packages/vite-plugin-checker/dist/@runtime'),
     tempRuntimePath,
     {
+      recursive: true,
       dereference: false,
     },
   )
 }
 
 export async function teardown(): Promise<void> {
-  fs.removeSync(tempRuntimePath)
+  rmSync(tempRuntimePath, { force: true, recursive: true })
 }