Migrate to JUnit 6

- Update version catalog: junit5-* → junit6-*, version 5.13.4 → 6.0.3
- Updated all `app/build.gradle.kts` alias references
- Removed broken top-level platform call from `core/build.gradle.kts`; moved BOM as implementation inside commonTest dependencies
- Fix nullability in `InstantExecutorExtension`
- `PostsDataSourcePinboardApiTest`: Extended AddTests.@beforeeach to also clear mockDao and mockConnectivityInfoProvider (JUnit 6 changed nested test execution order, causing mock state from NoConnectionTests to bleed into ItemAlreadyExists tests)

Author: fibelatti

app/build.gradle.kts

@@ -236,13 +236,13 @@ dependencies {
     testFixturesImplementation(platform(libs.compose.bom))
     testFixturesImplementation(libs.compose.runtime)
 
-    testImplementation(platform(libs.junit5.bom))
+    testImplementation(platform(libs.junit6.bom))
     testCompileOnly(libs.junit)
-    testRuntimeOnly(libs.junit5.engine)
-    testRuntimeOnly(libs.junit5.launcher)
-    testRuntimeOnly(libs.junit5.vintage)
-    testImplementation(libs.junit5.api)
-    testImplementation(libs.junit5.params)
+    testRuntimeOnly(libs.junit6.engine)
+    testRuntimeOnly(libs.junit6.launcher)
+    testRuntimeOnly(libs.junit6.vintage)
+    testImplementation(libs.junit6.api)
+    testImplementation(libs.junit6.params)
 
     testImplementation(libs.truth)
     testImplementation(libs.mockk)

app/src/test/kotlin/com/fibelatti/pinboard/InstantExecutorExtension.kt

@@ -8,7 +8,7 @@ import org.junit.jupiter.api.extension.ExtensionContext
 
 class InstantExecutorExtension : BeforeEachCallback, AfterEachCallback {
 
-    override fun beforeEach(context: ExtensionContext?) {
+    override fun beforeEach(context: ExtensionContext) {
         ArchTaskExecutor.getInstance().setDelegate(
             object : TaskExecutor() {
 
@@ -21,7 +21,7 @@ class InstantExecutorExtension : BeforeEachCallback, AfterEachCallback {
         )
     }
 
-    override fun afterEach(context: ExtensionContext?) {
+    override fun afterEach(context: ExtensionContext) {
         ArchTaskExecutor.getInstance().setDelegate(null)
     }
 }

app/src/test/kotlin/com/fibelatti/pinboard/features/posts/data/PostsDataSourcePinboardApiTest.kt

@@ -139,7 +139,8 @@ class PostsDataSourcePinboardApiTest {
 
         @BeforeEach
         fun setup() {
-            clearMocks(mockApi, mockUserRepository)
+            clearMocks(mockApi, mockUserRepository, mockDao, mockConnectivityInfoProvider)
+            every { mockConnectivityInfoProvider.isConnected() } returns true
         }
 
         @Test

core/build.gradle.kts

@@ -3,10 +3,6 @@ plugins {
     alias(libs.plugins.fibelatti.kotlin.library)
 }
 
-dependencies {
-    platform(libs.junit5.bom)
-}
-
 kotlin {
     jvm()
 
@@ -21,12 +17,13 @@ kotlin {
 
         commonTest {
             dependencies {
+                implementation(project.dependencies.platform(libs.junit6.bom))
                 compileOnly(libs.junit)
-                runtimeOnly(libs.junit5.engine)
-                runtimeOnly(libs.junit5.launcher)
-                runtimeOnly(libs.junit5.vintage)
-                implementation(libs.junit5.api)
-                implementation(libs.junit5.params)
+                runtimeOnly(libs.junit6.engine)
+                runtimeOnly(libs.junit6.launcher)
+                runtimeOnly(libs.junit6.vintage)
+                implementation(libs.junit6.api)
+                implementation(libs.junit6.params)
 
                 implementation(libs.truth)
                 implementation(libs.mockk)

gradle/libs.versions.toml

@@ -73,12 +73,12 @@ leakcanary = { module = "com.squareup.leakcanary:leakcanary-android", version =
 
 junit = { module = "junit:junit", version = "4.13.2" }
 
-junit5-bom = { module = "org.junit:junit-bom", version = "5.13.4" }
-junit5-api = { module = "org.junit.jupiter:junit-jupiter-api" }
-junit5-engine = { module = "org.junit.jupiter:junit-jupiter-engine" }
-junit5-params = { module = "org.junit.jupiter:junit-jupiter-params" }
-junit5-vintage = { module = "org.junit.vintage:junit-vintage-engine" }
-junit5-launcher = { module = "org.junit.platform:junit-platform-launcher" }
+junit6-bom = { module = "org.junit:junit-bom", version = "6.0.3" }
+junit6-api = { module = "org.junit.jupiter:junit-jupiter-api" }
+junit6-engine = { module = "org.junit.jupiter:junit-jupiter-engine" }
+junit6-params = { module = "org.junit.jupiter:junit-jupiter-params" }
+junit6-vintage = { module = "org.junit.vintage:junit-vintage-engine" }
+junit6-launcher = { module = "org.junit.platform:junit-platform-launcher" }
 
 runner = { module = "androidx.test:runner", version = "1.7.0" }
 orchestrator = { module = "androidx.test:orchestrator", version = "1.6.1" }