Merge pull request #27 from fidelity/fix_isnan

Fix a build error reported by using the Visual Studio build tool on Windows

Author: takojunior

.github/workflows/ci.yml

@@ -10,14 +10,15 @@ on:
 
 jobs:
   Test:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        python-version: [3.6, 3.7, 3.8, 3.9]
+        python-version: ['3.6', '3.7', '3.8', '3.9', '3.10']
+        os: [ubuntu-latest, macos-latest, windows-latest]
     steps:
-      - uses: actions/checkout@v2
-      - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }} on ${{ matrix.os }}
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
       - name: Check

CHANGELOG.txt

@@ -2,6 +2,13 @@
 CHANGELOG
 =========
 
+-------------------------------------------------------------------------------
+July, 13, 2022 1.3.4
+-------------------------------------------------------------------------------
+
+Minor:
+- Fix a compiling issue in using Visual Studio C++ compiler
+
 -------------------------------------------------------------------------------
 June, 28, 2022 1.3.3
 -------------------------------------------------------------------------------

sequential/_version.py

@@ -2,4 +2,4 @@
 # Copyright FMR LLC <opensource@fidelity.com>
 # SPDX-License-Identifier: GPL-2.0
 
-__version__ = "1.3.3"
+__version__ = "1.3.4"

sequential/backend/build_mdd.cpp

@@ -101,8 +101,8 @@ vector<int>* lgap, vector<int>* ugap){	//checks upper and lower gap constraints
 
 	for (int att = 0; att < (*lgap).size(); att++){
         // Original MPP repo uses zero to indicate non-presence of constraints. When (*lgap)[att] == 0, we skip over the constraint.
-        // Here we enable the case when lower bound of gap constraint is 0. If lower bound is not a number, we skip over the constraint.
-		if (isnan((*lgap)[att]))
+        // Here we enable the case when lower bound of gap constraint is 0. If lower bound is NaN (Not-A-Number) value, we skip over the constraint.
+		if (isnan(static_cast<double>((*lgap)[att])))
 			continue;
         // Original MPP repo uses abs(att[i] - att[i-1]) as the gap value. Here we remove abs().
 		if ((*attrs)[(*lgapi)[att]].at(i).at(endp - 1) - (*attrs)[(*lgapi)[att]].at(i).at(strp - 1) < (*lgap)[att])
@@ -111,8 +111,8 @@ vector<int>* lgap, vector<int>* ugap){	//checks upper and lower gap constraints
 
 	for (int att = 0; att < (*ugap).size(); att++){
         // Original MPP repo uses zero to indicate non-presence of constraints. When (*ugap)[att] == 0, we skip over the constraint.
-        // Here we enable the case when upper bound of gap constraint is 0. If upper bound is not a number, we skip over the constraint.
-		if (isnan((*ugap)[att]))
+        // Here we enable the case when upper bound of gap constraint is 0. If upper bound is NaN (Not-A-Number) value, we skip over the constraint.
+		if (isnan(static_cast<double>((*ugap)[att])))
 			continue;
         // Original MPP repo uses abs(att[i] - att[i-1]) as the gap value. Here we remove abs().
 		if ((*attrs)[(*ugapi)[att]].at(i).at(endp - 1) - (*attrs)[(*ugapi)[att]].at(i).at(strp - 1) > (*ugap)[att])