Skip to content

Confirmation dialog with progress: preserve dialog on action errors #2581

@jhou-pro

Description

@jhou-pro

Description

Confirmation dialog with progress was added as part of #2422 (see the Confirmation pre-actions with progress section), but it is required to make it more in line with Entity Master behaviour -- the confirmation dialog should not be closed if an action error occurs.

  • Leave the dialog open in the event of action errors.
    These include both retrieval (e.g., in producers) and saving (e.g., in companions) errors (and all other errors like networking / access / availability).
  • Make dialog actions enabled, hide the spinner and enable ESC cancellation in the event of action errors.
  • Ensure affirmative action works after errors -- starts action execution again.

Change overview

Confirmation preAction dialog with progress now remains open in the event of errors. Buttons become enabled again and the spinner is hidden, which indicates that the action stopped working, but didn't complete fully. The user can now repeat the process to observe the error toast again. Keys Space / Enter are respected and can be actioned multiple times without explicit tapping (ESC key too).

Expected outcome

More practical withProgress confirmation dialog, enabling the user to repeat the action, and to have a better chance of knowing whether the action has been completed in case they missed a toast error.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions