refine login route tests

Author: janishar

tests/routes/v1/login/index.test.ts

@@ -2,7 +2,8 @@ import { addHeaders } from '../../../auth/authentication/mock';
 
 // the mock for this class should be below all other mock imports
 import {
-	mockKeystoreCreate, mockUserFindByEmail, USER_EMAIL, USER_PASSWORD
+	mockKeystoreCreate, mockUserFindByEmail, createTokensSpy,
+	USER_EMAIL, USER_PASSWORD
 } from './mock';
 
 import supertest from 'supertest';
@@ -13,14 +14,18 @@ describe('Login Route', () => {
 	const endpoint = '/v1/login/basic';
 	const request = supertest(app);
 
-	beforeAll(() => {
+	beforeEach(() => {
 		mockKeystoreCreate.mockClear();
 		mockUserFindByEmail.mockClear();
+		createTokensSpy.mockClear();
 	});
 
 	it('Should throw error when empty body is sent', async () => {
 		const response = await addHeaders(request.post(endpoint));
 		expect(response.status).toBe(400);
+		expect(mockUserFindByEmail).toBeCalledTimes(0);
+		expect(mockKeystoreCreate).toBeCalledTimes(0);
+		expect(createTokensSpy).toBeCalledTimes(0);
 	});
 
 	it('Should throw error when email is only sent', async () => {
@@ -29,6 +34,9 @@ describe('Login Route', () => {
 		);
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/password/);
+		expect(mockUserFindByEmail).toBeCalledTimes(0);
+		expect(mockKeystoreCreate).toBeCalledTimes(0);
+		expect(createTokensSpy).toBeCalledTimes(0);
 	});
 
 	it('Should throw error when password is only sent', async () => {
@@ -37,6 +45,9 @@ describe('Login Route', () => {
 		);
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/email/);
+		expect(mockUserFindByEmail).toBeCalledTimes(0);
+		expect(mockKeystoreCreate).toBeCalledTimes(0);
+		expect(createTokensSpy).toBeCalledTimes(0);
 	});
 
 	it('Should throw error when email is not valid format', async () => {
@@ -45,6 +56,9 @@ describe('Login Route', () => {
 		);
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/valid email/);
+		expect(mockUserFindByEmail).toBeCalledTimes(0);
+		expect(mockKeystoreCreate).toBeCalledTimes(0);
+		expect(createTokensSpy).toBeCalledTimes(0);
 	});
 
 	it('Should throw error when password is not valid format', async () => {
@@ -56,6 +70,9 @@ describe('Login Route', () => {
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/password length/);
 		expect(response.body.message).toMatch(/6 char/);
+		expect(mockUserFindByEmail).toBeCalledTimes(0);
+		expect(mockKeystoreCreate).toBeCalledTimes(0);
+		expect(createTokensSpy).toBeCalledTimes(0);
 	});
 
 	it('Should throw error when user not registered for email', async () => {
@@ -66,6 +83,9 @@ describe('Login Route', () => {
 			}));
 		expect(response.status).toBe(400);
 		expect(response.body.message).toMatch(/not registered/);
+		expect(mockUserFindByEmail).toBeCalledTimes(1);
+		expect(mockKeystoreCreate).toBeCalledTimes(0);
+		expect(createTokensSpy).toBeCalledTimes(0);
 	});
 
 	it('Should throw error for wrong password', async () => {
@@ -76,6 +96,9 @@ describe('Login Route', () => {
 			}));
 		expect(response.status).toBe(401);
 		expect(response.body.message).toMatch(/authentication failure/i);
+		expect(mockUserFindByEmail).toBeCalledTimes(1);
+		expect(mockKeystoreCreate).toBeCalledTimes(0);
+		expect(createTokensSpy).toBeCalledTimes(0);
 	});
 
 	it('Should send success response for correct credentials', async () => {
@@ -96,5 +119,9 @@ describe('Login Route', () => {
 		expect(response.body.data.tokens).toBeDefined();
 		expect(response.body.data.tokens).toHaveProperty('accessToken');
 		expect(response.body.data.tokens).toHaveProperty('refreshToken');
+
+		expect(mockUserFindByEmail).toBeCalledTimes(1);
+		expect(mockKeystoreCreate).toBeCalledTimes(1);
+		expect(createTokensSpy).toBeCalledTimes(1);
 	});
 });

tests/routes/v1/login/mock.ts

@@ -3,11 +3,14 @@ import { IKeystore } from '../../../../src/database/model/Keystore';
 import { IUser } from '../../../../src/database/model/User';
 import { Types } from 'mongoose';
 import bcrypt from 'bcrypt';
+import * as authUtils from '../../../../src/auth/authUtils';
 
 export const USER_EMAIL = '[email protected]';
 export const USER_PASSWORD = 'abc123';
 export const USER_PASSWORD_HASH = bcrypt.hashSync(USER_PASSWORD, 10);
 
+export const createTokensSpy = jest.spyOn(authUtils, 'createTokens');
+
 export const mockKeystoreCreate =
 	jest.fn(
 		async (client: IUser, primaryKey: string, secondaryKey: string): Promise<IKeystore> => {