fix signup api

Author: janishar

src/database/repository/UserRepo.ts

@@ -52,7 +52,7 @@ export default class UserRepository {
 		const now = new Date();
 
 		const role = await Role.findOne({ code: roleCode }).select('+email +password').lean<IRole>().exec();
-		if (!role) throw new InternalError();
+		if (!role) throw new InternalError('Role must be defined');
 
 		user.roles = [role._id];
 		user.createdAt = user.updatedAt = now;

src/routes/v1/access/signup.ts

@@ -11,13 +11,14 @@ import schema from './schema';
 import asyncHandler from '../../../helpers/asyncHandler';
 import bcrypt from 'bcrypt';
 import _ from 'lodash';
+import { RoleCode } from '../../../database/model/Role';
 
 const router = express.Router();
 
 router.post('/basic', validator(schema.signup),
 	asyncHandler(async (req: RoleRequest, res, next) => {
 		const user = await UserRepo.findByEmail(req.body.email);
-		if (!user) throw new BadRequestError('User already registered');
+		if (user) throw new BadRequestError('User already registered');
 
 		const accessTokenKey = crypto.randomBytes(64).toString('hex');
 		const refreshTokenKey = crypto.randomBytes(64).toString('hex');
@@ -26,14 +27,15 @@ router.post('/basic', validator(schema.signup),
 		const { user: createdUser, keystore } = await UserRepo.create(<IUser>{
 			name: req.body.name,
 			email: req.body.email,
+			profilePicUrl: req.body.profilePicUrl,
 			password: passwordHash,
-		}, accessTokenKey, refreshTokenKey, req.currentRoleCode);
+		}, accessTokenKey, refreshTokenKey, RoleCode.LEARNER);
 
 		const tokens = await createTokens(createdUser, keystore.primaryKey, keystore.secondaryKey);
 		new SuccessResponse('Signup Successful', {
-			user: _.pick(user, ['name', 'email', 'roles']),
+			user: _.pick(createdUser, ['name', 'email', 'roles', 'profilePicUrl']),
 			tokens: tokens,
-		});
+		}).send(res);
 	}));
 
 module.exports = router;