Merge pull request #89 from figma/shopify-sync/utf8-fix

[Shopify Sync] Fix failure dump with invalid UTF-8

Author: dkeegan-figma

ruby/lib/minitest/queue/failure_formatter.rb

@@ -13,11 +13,9 @@ def initialize(test)
       end
 
       def to_s
-        [
-          header,
-          body,
-          "\n"
-        ].flatten.compact.join("\n")
+        s = +"#{header}\n#{body}\n\n"
+        s.encode!(Encoding::UTF_8, invalid: :replace, undef: :replace)
+        s
       end
 
       def to_h

ruby/test/minitest/queue/failure_formatter_test.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Minitest::Queue
+  class FailureFormatterTest < Minitest::Test
+    include ReporterTestHelper
+
+    def test_failure_formatter_to_h_can_be_json_dumped
+      test = result('test_json', failure: "\xD6".b)
+
+      formatter = FailureFormatter.new(test)
+
+      assert JSON.dump(formatter.to_h)
+    end
+  end
+end