Skip to content

Commit 74c04c5

Browse files
authored
Explicitly check the array length (#21)
1 parent 9665513 commit 74c04c5

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

javascript/dist/queue/BaseRunner.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,9 @@ class BaseRunner {
6666
try {
6767
const failedTests = await this.client.hGetAll(this.retriedBuildKey('error-reports'));
6868
console.log(`[ci-queue] Failed tests`, failedTests);
69-
const failedTestGroups = Object.values(failedTests).map(test => JSON.parse(test).test_group);
69+
const failedTestGroups = Object.keys(failedTests).length > 0
70+
? Object.values(failedTests).map(test => JSON.parse(test).test_group)
71+
: [];
7072
return failedTestGroups;
7173
}
7274
catch (e) {

javascript/src/queue/BaseRunner.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,9 @@ export class BaseRunner {
8484
try {
8585
const failedTests = await this.client.hGetAll(this.retriedBuildKey('error-reports'));
8686
console.log(`[ci-queue] Failed tests`, failedTests);
87-
const failedTestGroups = Object.values(failedTests).map(test => JSON.parse(test).test_group);
87+
const failedTestGroups = Object.keys(failedTests).length > 0
88+
? Object.values(failedTests).map(test => JSON.parse(test).test_group)
89+
: [];
8890
return failedTestGroups;
8991
} catch (e) {
9092
// If the previous build is still in-progress, there may not be any failed tests

0 commit comments

Comments
 (0)