Merge branch '4.x' into 5.x

Author: danharrin

packages/forms/src/Components/RichEditor.php

@@ -52,7 +52,7 @@ class RichEditor extends Field implements Contracts\CanBeLengthConstrained
     /**
      * @var array<string> | Closure
      */
-    protected array | Closure $linkProtocols = ['http', 'https', 'mailto'];
+    protected array | Closure $linkProtocols = ['http', 'https', 'ftp', 'ftps', 'mailto', 'tel', 'callto', 'sms', 'cid', 'xmpp'];
 
     protected bool | Closure | null $isJson = null;
 
@@ -574,6 +574,7 @@ public function getTipTapEditor(): Editor
     {
         return RichContentRenderer::make()
             ->plugins($this->getPlugins())
+            ->linkProtocols($this->getLinkProtocols())
             ->getEditor();
     }
 

packages/forms/src/Components/RichEditor/RichContentRenderer.php

@@ -104,6 +104,11 @@ class RichContentRenderer implements Htmlable
      */
     protected ?array $textColors = null;
 
+    /**
+     * @var ?array<string>
+     */
+    protected ?array $linkProtocols = null;
+
     /**
      * @param  string | array<string, mixed> | null  $content
      */
@@ -392,7 +397,11 @@ public function getTipTapPhpExtensions(): array
             app(Italic::class),
             app(ImageExtension::class),
             app(LeadExtension::class),
-            app(Link::class),
+            app(Link::class, [
+                'options' => [
+                    'allowedProtocols' => $this->getLinkProtocols(),
+                ],
+            ]),
             app(ListItem::class),
             app(MentionExtension::class),
             app(MergeTagExtension::class),
@@ -597,4 +606,22 @@ public function getTextColors(): array
             fn (string | TextColor $color, string $name): array => [$name => ($color instanceof TextColor) ? $color : TextColor::make($color, $name)],
         );
     }
+
+    /**
+     * @param  ?array<string>  $protocols
+     */
+    public function linkProtocols(?array $protocols): static
+    {
+        $this->linkProtocols = $protocols;
+
+        return $this;
+    }
+
+    /**
+     * @return array<string>
+     */
+    public function getLinkProtocols(): array
+    {
+        return $this->linkProtocols ?? app(Link::class)->options['allowedProtocols'];
+    }
 }

tests/src/Forms/Components/RichEditor/RichContentRendererTest.php

@@ -770,3 +770,50 @@ public function toHtml(): string
 
     expect($html)->toContain('<span data-type="mention" data-id="1" data-char="@"></span>');
 });
+
+it('preserves links with default protocols', function (): void {
+    $renderer = RichContentRenderer::make(
+        '<p><a href="https://example.com">Link</a></p>',
+    );
+
+    $html = $renderer->toUnsafeHtml();
+
+    expect($html)->toContain('href="https://example.com"');
+});
+
+it('strips links with unknown protocols by default', function (): void {
+    $renderer = RichContentRenderer::make(
+        '<p><a href="myapp:///path"><strong>Link</strong></a></p>',
+    );
+
+    $html = $renderer->toUnsafeHtml();
+
+    expect($html)->not->toContain('myapp:///path');
+});
+
+it('preserves links with custom protocols when `linkProtocols()` includes them', function (): void {
+    $renderer = RichContentRenderer::make(
+        '<p><a href="myapp:///cards?id=123"><strong>Open App</strong></a></p>',
+    );
+
+    $renderer->linkProtocols([
+        ...RichContentRenderer::make()->getLinkProtocols(),
+        'myapp',
+    ]);
+
+    $html = $renderer->toUnsafeHtml();
+
+    expect($html)->toContain('href="myapp:///cards?id=123"');
+});
+
+it('uses default protocols from `Link` when `linkProtocols()` is not set', function (): void {
+    $renderer = RichContentRenderer::make();
+
+    $protocols = $renderer->getLinkProtocols();
+
+    expect($protocols)
+        ->toContain('http')
+        ->toContain('https')
+        ->toContain('mailto')
+        ->toContain('tel');
+});