From d5dddac8b2fe5b447d25cc7a733b1ea8221aa6a2 Mon Sep 17 00:00:00 2001 From: zenground0 Date: Mon, 29 Apr 2024 10:38:45 -0600 Subject: [PATCH 1/4] Add ReplicaInfo --- FIPS/fip-0090.md | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/FIPS/fip-0090.md b/FIPS/fip-0090.md index e3d28aca7..7fe2fcdfc 100644 --- a/FIPS/fip-0090.md +++ b/FIPS/fip-0090.md @@ -97,13 +97,25 @@ Note that, same as with interactive PoRep, each sector has a `SealRandEpoch` tha - Introduce a new method `ProveCommitSectorsNI` (method 36), which performs a non-interactive proof for CC sectors, without a preceding PreCommitSector message (ie, this method rejects sectors that were already pre-committed. Such sectors must be activated with one of the existing ProveCommit methods). The method can be used with seal proofs or aggregate proof (but only one option can be chosen per call); the return type is the same as `ProveCommitAggregate`. ```go - // Note no UnsealedCID because it must be "zero" data. + // Note no UnsealedCID because it must be "zero" data. struct SectorNIActivationInfo { - SectorNumber: SectorNumber, + ReplicaInfo: ReplicaInfo SealedCID: Cid, // CommR SealRandEpoch: ChainEpoch, Expiration: ChainEpoch, } + + // Organize information used in replica id + // Included to avoid breaking change for future SealerActor FIP + struct ReplicaInfo { + // Sector number used to generate replica id + // Must be set to SectorID + SectorNumber: SectorNumber, + // Sector number used as unique id in actor state + SectorID: SectorNumber, + // Must be set to ProviderID + SealerID: ActorID + } struct ProveCommitSectorsNIParams { // Information about sealing of each sector. From a82b170fa50e7f0d136a8aa715963aa5adf5becb Mon Sep 17 00:00:00 2001 From: zenground0 Date: Mon, 29 Apr 2024 10:41:03 -0600 Subject: [PATCH 2/4] typo --- FIPS/fip-0090.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FIPS/fip-0090.md b/FIPS/fip-0090.md index 7fe2fcdfc..e11efbafa 100644 --- a/FIPS/fip-0090.md +++ b/FIPS/fip-0090.md @@ -110,7 +110,7 @@ Note that, same as with interactive PoRep, each sector has a `SealRandEpoch` tha struct ReplicaInfo { // Sector number used to generate replica id // Must be set to SectorID - SectorNumber: SectorNumber, + SectorNumber: SectorNumber, // Sector number used as unique id in actor state SectorID: SectorNumber, // Must be set to ProviderID From 04c54c9648b10646fb76a51210c90e3b62e2921f Mon Sep 17 00:00:00 2001 From: zenground0 Date: Thu, 2 May 2024 13:21:09 -0600 Subject: [PATCH 3/4] Review Response --- FIPS/fip-0090.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/FIPS/fip-0090.md b/FIPS/fip-0090.md index e11efbafa..033b5a5d8 100644 --- a/FIPS/fip-0090.md +++ b/FIPS/fip-0090.md @@ -97,9 +97,9 @@ Note that, same as with interactive PoRep, each sector has a `SealRandEpoch` tha - Introduce a new method `ProveCommitSectorsNI` (method 36), which performs a non-interactive proof for CC sectors, without a preceding PreCommitSector message (ie, this method rejects sectors that were already pre-committed. Such sectors must be activated with one of the existing ProveCommit methods). The method can be used with seal proofs or aggregate proof (but only one option can be chosen per call); the return type is the same as `ProveCommitAggregate`. ```go - // Note no UnsealedCID because it must be "zero" data. + // Note no UnsealedCID because it must be "zero" data. struct SectorNIActivationInfo { - ReplicaInfo: ReplicaInfo + ReplicaInfo: ReplicaInfo SealedCID: Cid, // CommR SealRandEpoch: ChainEpoch, Expiration: ChainEpoch, @@ -110,7 +110,7 @@ Note that, same as with interactive PoRep, each sector has a `SealRandEpoch` tha struct ReplicaInfo { // Sector number used to generate replica id // Must be set to SectorID - SectorNumber: SectorNumber, + SealingNumber: SectorNumber, // Sector number used as unique id in actor state SectorID: SectorNumber, // Must be set to ProviderID From 6305cf5621ea3383b51e1dbc61b0c944b46c635c Mon Sep 17 00:00:00 2001 From: zenground0 Date: Sun, 5 May 2024 22:01:36 -0600 Subject: [PATCH 4/4] Review Response --- FIPS/fip-0090.md | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/FIPS/fip-0090.md b/FIPS/fip-0090.md index 033b5a5d8..78f11d04e 100644 --- a/FIPS/fip-0090.md +++ b/FIPS/fip-0090.md @@ -99,23 +99,13 @@ Note that, same as with interactive PoRep, each sector has a `SealRandEpoch` tha ```go // Note no UnsealedCID because it must be "zero" data. struct SectorNIActivationInfo { - ReplicaInfo: ReplicaInfo + SealingNumber: SectorNumber, // Sector number used to generate replica id + SealerID: ActorID, // Must be set to ID of receiving actor for now SealedCID: Cid, // CommR + SectorNumber: SectorNumber, // unique id of sector in actor state SealRandEpoch: ChainEpoch, Expiration: ChainEpoch, } - - // Organize information used in replica id - // Included to avoid breaking change for future SealerActor FIP - struct ReplicaInfo { - // Sector number used to generate replica id - // Must be set to SectorID - SealingNumber: SectorNumber, - // Sector number used as unique id in actor state - SectorID: SectorNumber, - // Must be set to ProviderID - SealerID: ActorID - } struct ProveCommitSectorsNIParams { // Information about sealing of each sector.