Basic CI / GitHub actions (#6)

* add formatting and clippy CI checks

* don't treat clippy warnings as errors during normal branch pushes

* add a stricter check for PRs which includes a build

This will take longer to run so is only done on PR events. Also treats clippy warnings as errors.

* move the cargo commands to a Makefile and use that in the action scripts

The Makefile also has basic build and clean targets for convenience during local development

* clippy fix

Author: abright

.github/workflows/check-pr.yml

@@ -0,0 +1,22 @@
+name: Rust PR check
+
+on:
+  pull_request:
+    # Default types for PR are opened, synchronize, reopened. Need
+    # ready_for_review to catch a PR that is moving from draft to not-draft
+    types: [opened, synchronize, reopened, ready_for_review]
+
+env:
+  CARGO_TERM_COLOR: always
+
+jobs:
+  check-code:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Build
+        run: make check-build
+
+      # TODO: run tests

.github/workflows/check-push.yml

@@ -0,0 +1,16 @@
+name: Rust code checks
+
+on: [push]
+
+env:
+  CARGO_TERM_COLOR: always
+
+jobs:
+  check-code:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Code checks
+        run: make check

Makefile

@@ -0,0 +1,12 @@
+build:
+	cargo build --workspace
+
+check-build: check
+	cargo build --workspace --all-targets --all-features
+
+check:
+	cargo fmt --check
+	cargo clippy --workspace --all-targets --all-features -- -D warnings
+
+clean:
+	cargo clean

fvm_dispatch/src/hash.rs

@@ -104,7 +104,7 @@ mod tests {
     struct FakeHasher {}
     impl Hasher for FakeHasher {
         fn hash(&self, bytes: &[u8]) -> Vec<u8> {
-            return bytes.to_vec();
+            bytes.to_vec()
         }
     }