test: fetch actors bundle from github instead of using cargo

Primarily, this removes an annoying circular dependency between these
utilities and the actors. Additionally, this makes it very clear that
the actors we're building won't use the code in this repo. Unlike normal
rust builds, actor bundle builds don't automatically patch workspaces.

I've configured it to fetch v15 and we'll have to update that as we go.
If you want to test with newer actors, you'll need to build a bundle
yourself and drop it in `testing/bundles/builtin-actors.car`.

Part of filecoin-project/builtin-actors#1664

Author: Stebalien

.gitignore

@@ -16,3 +16,5 @@ Cargo.lock
 # Code coverage instrumentation
 coverage/
 *.profraw
+
+testing/bundles/

Makefile

@@ -9,6 +9,11 @@ WASM_EXCLUSION = \
 	--exclude frc46_factory_token \
 	--exclude frc53_test_actor
 
+ACTORS_VERSION=v15.0.0
+ACTORS_NETWORK=mainnet
+ACTORS_BUNDLE_NAME=builtin-actors-${ACTORS_VERSION}-${ACTORS_NETWORK}.car
+ACTORS_URL=https://github.com/filecoin-project/builtin-actors/releases/download/${ACTORS_VERSION}/builtin-actors-${ACTORS_NETWORK}.car
+
 # actors are built to WASM via the helix_test_actors crate and be built individually as standalone
 # crates so we exclude the from this convenience target
 build: install-toolchain
@@ -20,18 +25,30 @@ check: install-toolchain
 
 check-build: check build
 
+
+testing/bundles/${ACTORS_BUNDLE_NAME}:
+	curl -fL --create-dirs --output $@ ${ACTORS_URL}
+
+fetch-bundle: testing/bundles/${ACTORS_BUNDLE_NAME}
+	ln -sf ${ACTORS_BUNDLE_NAME} testing/bundles/builtin-actors.car
+.PHONY: fetch-bundle
+
+
+test-deps: install-toolchain fetch-bundle
+.PHONY: test-deps
+
 # run all tests, this will not work if using RUSTFLAGS="-Zprofile" to generate profile info or coverage reports
 # as any WASM targets will fail to build
-test: install-toolchain
+test: test-deps
 	cargo test
 
 # tests excluding actors so we can generate coverage reports during CI build
 # WASM targets such as actors do not support this so are excluded
-test-coverage: install-toolchain
+test-coverage: test-deps
 	cargo test --workspace $(WASM_EXCLUSION)
 
 # separate actor testing stage to run from CI without coverage support
-test-actors: install-toolchain
+test-actors: test-deps
 	cargo test --package greeter --package helix_integration_tests
 
 install-toolchain:
@@ -44,6 +61,7 @@ clean:
 	cargo clean
 	find . -name '*.profraw' -delete
 	rm Cargo.lock
+	rm -r testing/bundles
 
 # generate local coverage report in html format using grcov
 # install it with `cargo install grcov`

testing/integration/Cargo.toml

@@ -23,6 +23,6 @@ serde = { workspace = true }
 serde_tuple = { workspace = true }
 
 [dev-dependencies]
-actors = { package = "fil_builtin_actors_bundle", git = "https://github.com/filecoin-project/builtin-actors", branch = "master" }
 helix_test_actors = { path = "../test_actors" }
+reqwest = "0.12.15"
 token_impl = { path = "../test_actors/actors/frc46_factory_token/token_impl" }

testing/integration/tests/common/mod.rs

@@ -18,6 +18,8 @@ use serde::Serialize;
 pub mod frc46_token_helpers;
 pub mod frc53_nft_helpers;
 
+static BUNDLE_CAR: &'static [u8] = include_bytes!("../../../bundles/builtin-actors.car");
+
 /// Helper routines to simplify common operations with a [`Tester`].
 pub trait TestHelpers {
     /// Call a method on an actor.
@@ -65,7 +67,7 @@ pub fn load_actor_wasm(path: &str) -> Vec<u8> {
 /// This mainly cuts down on noise with importing the built-in actor bundle and network/state tree
 /// versions.
 pub fn construct_tester<BS: Blockstore + Clone, E: Externs>(blockstore: &BS) -> Tester<BS, E> {
-    let bundle_root = bundle::import_bundle(&blockstore, actors::BUNDLE_CAR).unwrap();
+    let bundle_root = bundle::import_bundle(&blockstore, BUNDLE_CAR).unwrap();
 
     Tester::new(NetworkVersion::V21, StateTreeVersion::V5, bundle_root, blockstore.clone()).unwrap()
 }

testing/integration/tests/frc46_tokens.rs

@@ -2,21 +2,21 @@ use cid::Cid;
 use frc42_dispatch::method_hash;
 use frc46_token::token::{state::TokenState, types::MintReturn};
 use fvm::executor::{ApplyKind, Executor};
-use fvm_integration_tests::bundle;
 use fvm_integration_tests::dummy::DummyExterns;
-use fvm_integration_tests::tester::{Account, Tester};
+use fvm_integration_tests::tester::Account;
 use fvm_ipld_blockstore::MemoryBlockstore;
 use fvm_ipld_encoding::RawBytes;
 use fvm_shared::address::Address;
 use fvm_shared::bigint::Zero;
 use fvm_shared::econ::TokenAmount;
 use fvm_shared::message::Message;
-use fvm_shared::state::StateTreeVersion;
-use fvm_shared::version::NetworkVersion;
 use helix_test_actors::BASIC_RECEIVING_ACTOR_BINARY;
 use helix_test_actors::BASIC_TOKEN_ACTOR_BINARY;
 use serde_tuple::{Deserialize_tuple, Serialize_tuple};
 
+mod common;
+use common::construct_tester;
+
 // Duplicated type from basic_token_actor
 #[derive(Serialize_tuple, Deserialize_tuple, Clone, Debug)]
 pub struct MintParams {
@@ -28,10 +28,7 @@ pub struct MintParams {
 #[test]
 fn it_mints_tokens() {
     let blockstore = MemoryBlockstore::default();
-    let bundle_root = bundle::import_bundle(&blockstore, actors::BUNDLE_CAR).unwrap();
-    let mut tester =
-        Tester::new(NetworkVersion::V21, StateTreeVersion::V5, bundle_root, blockstore.clone())
-            .unwrap();
+    let mut tester = construct_tester(&blockstore);
 
     let minter: [Account; 1] = tester.create_accounts().unwrap();