fix: out of bounds access in ListFlaggedPieces (#1927)

jmg-duarte · web-flow · commit ff7d140f6f3e · 2024-06-17T13:53:09.000+04:00
diff --git a/extern/boostd-data/ldb/db.go b/extern/boostd-data/ldb/db.go
@@ -785,8 +785,10 @@ func (db *DB) ListFlaggedPieces(ctx context.Context, filter *types.FlaggedPieces
 		}
 	}
 
-	if len(records) > limit {
-		records = records[:limit]
+	if limit > 0 {
+		if len(records) > limit {
+			records = records[:limit]
+		}
 	}
 
 	return records, nil

Original file line number	Diff line number	Diff line change
`@@ -785,8 +785,10 @@ func (db DB) ListFlaggedPieces(ctx context.Context, filter types.FlaggedPieces`
`785`	`785`	`}`
`786`	`786`	`}`
`787`	`787`
`788`		`- if len(records) > limit {`
`789`		`- records = records[:limit]`
	`788`	`+ if limit > 0 {`
	`789`	`+ if len(records) > limit {`
	`790`	`+ records = records[:limit]`
	`791`	`+ }`
`790`	`792`	`}`
`791`	`793`
`792`	`794`	`return records, nil`