chore: address review comments

Author: tediou5

actors/miner/tests/miner_actor_test_construction.rs

@@ -21,7 +21,7 @@ use fvm_ipld_encoding::ipld_block::IpldBlock;
 use num_traits::{FromPrimitive, Zero};
 
 mod util;
-use util::minimum_initial_pledge;
+use util::create_miner_deposit_for_test;
 
 #[allow(dead_code)]
 struct TestEnv {
@@ -65,7 +65,11 @@ fn prepare_env() -> TestEnv {
     env.rt.caller.replace(INIT_ACTOR_ADDR);
     env.rt.caller_type.replace(*INIT_ACTOR_CODE_ID);
     // add balance for create miner deposit
-    env.rt.add_balance(minimum_initial_pledge(&env.rt, &env.power, &env.epoch_reward_smooth));
+    env.rt.add_balance(create_miner_deposit_for_test(
+        &env.rt,
+        &env.power,
+        &env.epoch_reward_smooth,
+    ));
     env
 }
 
@@ -139,7 +143,7 @@ fn simple_construction() {
 
     assert_eq!(TokenAmount::zero(), state.pre_commit_deposits);
     assert_eq!(
-        minimum_initial_pledge(&env.rt, &env.power, &env.epoch_reward_smooth),
+        create_miner_deposit_for_test(&env.rt, &env.power, &env.epoch_reward_smooth),
         state.locked_funds
     );
     assert_eq!(180, state.vesting_funds.load(&env.rt.store).unwrap().len());

actors/miner/tests/util.rs

@@ -133,7 +133,7 @@ pub fn setup() -> (ActorHarness, MockRuntime) {
     (h, rt)
 }
 
-pub fn minimum_initial_pledge(
+pub fn create_miner_deposit_for_test(
     rt: &MockRuntime,
     baseline_power: &StoragePower,
     reward_estimated: &FilterEstimate,
@@ -241,7 +241,7 @@ impl ActorHarness {
 
     pub fn check_create_miner_deposit_and_reset_state(&self, rt: &MockRuntime) {
         let create_deposit =
-            minimum_initial_pledge(rt, &self.baseline_power, &self.epoch_reward_smooth);
+            create_miner_deposit_for_test(rt, &self.baseline_power, &self.epoch_reward_smooth);
 
         let mut st = self.get_state(&rt);
         let create_deposit_vesting_funds = st.vesting_funds.load(&rt.store).unwrap();
@@ -313,7 +313,11 @@ impl ActorHarness {
 
         // set circulating supply non-zero so we get non-zero fees
         rt.set_circulating_supply(TokenAmount::from_whole(500_000));
-        rt.add_balance(minimum_initial_pledge(rt, &self.baseline_power, &self.epoch_reward_smooth));
+        rt.add_balance(create_miner_deposit_for_test(
+            rt,
+            &self.baseline_power,
+            &self.epoch_reward_smooth,
+        ));
         rt.set_caller(*INIT_ACTOR_CODE_ID, INIT_ACTOR_ADDR);
         rt.expect_validate_caller_addr(vec![INIT_ACTOR_ADDR]);
         rt.expect_send_simple(

integration_tests/src/util/mod.rs

@@ -44,7 +44,6 @@ use crate::{MinerBalances, NetworkStats, TEST_FAUCET_ADDR};
 mod workflows;
 
 const ACCOUNT_SEED: u64 = 93837778;
-pub const CREATE_MINER_DEPOSIT: u128 = 319999994978159820800;
 
 /// Returns addresses of created accounts in ID format
 pub fn create_accounts(v: &dyn VM, count: u64, balance: &TokenAmount) -> Vec<Address> {
@@ -289,7 +288,7 @@ pub fn get_network_stats(vm: &dyn VM) -> NetworkStats {
     }
 }
 
-pub fn get_minimum_initial_pledge(vm: &dyn VM) -> TokenAmount {
+pub fn create_miner_deposit_for_test(vm: &dyn VM) -> TokenAmount {
     let power_state: PowerState = get_state(vm, &STORAGE_POWER_ACTOR_ADDR).unwrap();
     let reward_state: RewardState = get_state(vm, &REWARD_ACTOR_ADDR).unwrap();
 

integration_tests/src/util/workflows.rs

@@ -85,7 +85,7 @@ use vm_api::util::{apply_code, apply_ok, apply_ok_implicit};
 use crate::expects::Expect;
 use crate::*;
 
-use super::get_minimum_initial_pledge;
+use super::create_miner_deposit_for_test;
 use super::market_pending_deal_allocations_raw;
 use super::miner_dline_info;
 use super::sector_deadline;
@@ -102,7 +102,7 @@ pub fn cron_tick(v: &dyn VM) {
 }
 
 pub fn owner_add_create_miner_deposit(v: &dyn VM, owner: &Address) -> TokenAmount {
-    let create_miner_deposit = get_minimum_initial_pledge(v);
+    let create_miner_deposit = create_miner_deposit_for_test(v);
     apply_ok(
         v,
         &TEST_FAUCET_ADDR,