Implement voucher_invalid_after_settling unit test for paych actor. (#215)

* Implement voucher_invalid_after_settling unit test for paych actor.

* Define ERR_CHANNEL_STATE_UPDATE_AFTER_SETTLED.

Author: lemmih

actors/paych/tests/paych_actor_test.rs

@@ -376,7 +376,7 @@ mod update_channel_state_redeem {
 
     #[test]
     fn redeem_voucher_one_lane() {
-        let (mut rt, mut sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, mut sv) = require_create_channel_with_lanes(1);
         let state: PState = rt.get_state().unwrap();
         let payee_addr = Address::new_id(PAYEE_ID);
 
@@ -415,7 +415,7 @@ mod update_channel_state_redeem {
 
     #[test]
     fn redeem_voucher_correct_lane() {
-        let (mut rt, mut sv) = require_create_cannel_with_lanes(3);
+        let (mut rt, mut sv) = require_create_channel_with_lanes(3);
         let state: PState = rt.get_state().unwrap();
         let payee_addr = Address::new_id(PAYEE_ID);
 
@@ -460,7 +460,7 @@ mod merge_tests {
     use super::*;
 
     fn construct_runtime(num_lanes: u64) -> (MockRuntime, SignedVoucher, PState) {
-        let (mut rt, sv) = require_create_cannel_with_lanes(num_lanes);
+        let (mut rt, sv) = require_create_channel_with_lanes(num_lanes);
         let state: PState = rt.get_state().unwrap();
         rt.set_caller(*ACCOUNT_ACTOR_CODE_ID, state.from);
         rt.expect_validate_caller_addr(vec![state.from, state.to]);
@@ -582,7 +582,7 @@ mod merge_tests {
     #[test]
     fn invalid_merge_lane_999() {
         let num_lanes = 2;
-        let (mut rt, mut sv) = require_create_cannel_with_lanes(num_lanes);
+        let (mut rt, mut sv) = require_create_channel_with_lanes(num_lanes);
         let state: PState = rt.get_state().unwrap();
 
         sv.lane = 0;
@@ -616,7 +616,7 @@ mod update_channel_state_extra {
     const OTHER_ADDR: u64 = 104;
 
     fn construct_runtime(exit_code: ExitCode) -> (MockRuntime, SignedVoucher) {
-        let (mut rt, mut sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, mut sv) = require_create_channel_with_lanes(1);
         let state: PState = rt.get_state().unwrap();
         let other_addr = Address::new_id(OTHER_ADDR);
         let fake_params = [1, 2, 3, 4];
@@ -677,7 +677,7 @@ mod update_channel_state_extra {
 
 #[test]
 fn update_channel_settling() {
-    let (mut rt, sv) = require_create_cannel_with_lanes(1);
+    let (mut rt, sv) = require_create_channel_with_lanes(1);
     rt.epoch = 10;
     let state: PState = rt.get_state().unwrap();
     rt.expect_validate_caller_addr(vec![state.from, state.to]);
@@ -732,7 +732,7 @@ mod secret_preimage {
 
     #[test]
     fn succeed_correct_secret() {
-        let (mut rt, sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, sv) = require_create_channel_with_lanes(1);
         let state: PState = rt.get_state().unwrap();
         rt.expect_validate_caller_addr(vec![state.from, state.to]);
 
@@ -752,7 +752,7 @@ mod secret_preimage {
 
     #[test]
     fn incorrect_secret() {
-        let (mut rt, sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, sv) = require_create_channel_with_lanes(1);
 
         let state: PState = rt.get_state().unwrap();
 
@@ -785,7 +785,7 @@ mod actor_settle {
     const EP: i64 = 10;
     #[test]
     fn adjust_settling_at() {
-        let (mut rt, _sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, _sv) = require_create_channel_with_lanes(1);
         rt.epoch = EP;
         let mut state: PState = rt.get_state().unwrap();
         rt.set_caller(*ACCOUNT_ACTOR_CODE_ID, state.from);
@@ -801,7 +801,7 @@ mod actor_settle {
 
     #[test]
     fn call_twice() {
-        let (mut rt, _sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, _sv) = require_create_channel_with_lanes(1);
         rt.epoch = EP;
         let state: PState = rt.get_state().unwrap();
         rt.set_caller(*ACCOUNT_ACTOR_CODE_ID, state.from);
@@ -819,7 +819,7 @@ mod actor_settle {
 
     #[test]
     fn settle_if_height_less() {
-        let (mut rt, mut sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, mut sv) = require_create_channel_with_lanes(1);
         rt.epoch = EP;
         let mut state: PState = rt.get_state().unwrap();
 
@@ -847,6 +847,35 @@ mod actor_settle {
         state = rt.get_state().unwrap();
         assert_eq!(state.settling_at, ucp.sv.min_settle_height);
     }
+
+    #[test]
+    fn voucher_invalid_after_settling() {
+        const ERR_CHANNEL_STATE_UPDATE_AFTER_SETTLED: ExitCode = ExitCode::new(32);
+
+        let (mut rt, sv) = require_create_channel_with_lanes(1);
+        rt.epoch = EP;
+        let mut state: PState = rt.get_state().unwrap();
+        rt.set_caller(*ACCOUNT_ACTOR_CODE_ID, state.from);
+        rt.expect_validate_caller_addr(vec![state.from, state.to]);
+
+        call(&mut rt, Method::Settle as u64, &RawBytes::default());
+
+        state = rt.get_state().unwrap();
+        rt.epoch = state.settling_at + 40;
+        rt.expect_validate_caller_addr(vec![state.from, state.to]);
+        rt.expect_verify_signature(ExpectedVerifySig {
+            sig: sv.clone().signature.unwrap(),
+            signer: Address::new_id(PAYEE_ID),
+            plaintext: sv.signing_bytes().unwrap(),
+            result: Ok(()),
+        });
+        expect_error(
+            &mut rt,
+            Method::UpdateChannelState as u64,
+            &RawBytes::serialize(UpdateChannelStateParams::from(sv)).unwrap(),
+            ERR_CHANNEL_STATE_UPDATE_AFTER_SETTLED,
+        );
+    }
 }
 
 mod actor_collect {
@@ -856,7 +885,7 @@ mod actor_collect {
 
     #[test]
     fn happy_path() {
-        let (mut rt, _sv) = require_create_cannel_with_lanes(1);
+        let (mut rt, _sv) = require_create_channel_with_lanes(1);
         let curr_epoch: ChainEpoch = 10;
         rt.epoch = curr_epoch;
         let st: PState = rt.get_state().unwrap();
@@ -914,7 +943,7 @@ mod actor_collect {
         ];
 
         for tc in test_cases {
-            let (mut rt, _sv) = require_create_cannel_with_lanes(1);
+            let (mut rt, _sv) = require_create_channel_with_lanes(1);
             rt.epoch = 10;
             let mut state: PState = rt.get_state().unwrap();
 
@@ -950,7 +979,7 @@ mod actor_collect {
     }
 }
 
-fn require_create_cannel_with_lanes(num_lanes: u64) -> (MockRuntime, SignedVoucher) {
+fn require_create_channel_with_lanes(num_lanes: u64) -> (MockRuntime, SignedVoucher) {
     let paych_addr = Address::new_id(100);
     let payer_addr = Address::new_id(PAYER_ID);
     let payee_addr = Address::new_id(PAYEE_ID);