Feature/multisig actor (#83)

Signed-off-by: Alexey-N-Chernyshov <[email protected]>

Author: Alexey-N-Chernyshov

.github/workflows/ci.yml

@@ -1,6 +1,6 @@
 name: CI
 
-on: 
+on:
   push:
     branches:
     - master

core/primitives/big_int.hpp

@@ -29,6 +29,18 @@ namespace fc::primitives {
     return static_cast<cpp_int>(lhs) * static_cast<cpp_int>(rhs);
   }
 
+  static inline BigInt operator*(const BigInt &rhs, unsigned long long lhs) {
+    return static_cast<cpp_int>(lhs) * static_cast<cpp_int>(rhs);
+  }
+
+  static inline BigInt operator/(const BigInt &lhs, const BigInt &rhs) {
+    return static_cast<cpp_int>(lhs) / static_cast<cpp_int>(rhs);
+  }
+
+  static inline BigInt operator/(const BigInt &lhs, unsigned long long rhs) {
+    return static_cast<cpp_int>(lhs) / static_cast<cpp_int>(rhs);
+  }
+
   static inline BigInt operator+(const BigInt &lhs, const BigInt &rhs) {
     return static_cast<cpp_int>(lhs) + static_cast<cpp_int>(rhs);
   }
@@ -57,6 +69,10 @@ namespace fc::primitives {
     return static_cast<cpp_int>(lhs) < static_cast<cpp_int>(rhs);
   }
 
+  static inline bool operator<(const BigInt &lhs, unsigned long long rhs) {
+    return static_cast<cpp_int>(lhs) < rhs;
+  }
+
   static inline bool operator<(const BigInt &lhs, int rhs) {
     return static_cast<cpp_int>(lhs) < rhs;
   }
@@ -69,6 +85,14 @@ namespace fc::primitives {
     return static_cast<cpp_int>(lhs) == rhs;
   }
 
+  static inline bool operator==(const UBigInt &lhs, const UBigInt &rhs) {
+    return static_cast<cpp_int>(lhs) == static_cast<cpp_int>(rhs);
+  }
+
+  static inline bool operator==(const UBigInt &lhs, int rhs) {
+    return static_cast<cpp_int>(lhs) == static_cast<cpp_int>(rhs);
+  }
+
   template <class Stream,
             class T,
             typename = std::enable_if_t<
@@ -85,13 +109,12 @@ namespace fc::primitives {
     return s << bytes;
   }
 
-  template <
-      class Stream,
-      class T,
-      typename = std::enable_if_t<
-          (std::is_same_v<T, BigInt> || std::is_same_v<T, UBigInt>)&&Stream::
-              is_cbor_decoder_stream>>
-  Stream &operator>>(Stream &s, T &big_int) {
+  template <class Stream,
+            class T,
+            typename = std::enable_if_t<
+                (std::is_same_v<T, BigInt> || std::is_same_v<T, UBigInt>)&&std::
+                    remove_reference_t<Stream>::is_cbor_decoder_stream>>
+  Stream &operator>>(Stream &&s, T &big_int) {
     std::vector<uint8_t> bytes;
     s >> bytes;
     if (bytes.empty()) {

core/primitives/chain_epoch.hpp

@@ -7,6 +7,7 @@
 #define CPP_FILECOIN_PRIMITIVES_CHAIN_EPOCH_HPP
 
 #include "libp2p/multi/uvarint.hpp"
+#include "primitives/big_int.hpp"
 
 namespace fc::primitives {
 
@@ -16,6 +17,8 @@ namespace fc::primitives {
    */
   using ChainEpoch = libp2p::multi::UVarint;
 
+  using EpochDuration = BigInt;
+
 }  // namespace fc::primitives
 
 #endif  // CPP_FILECOIN_PRIMITIVES_CHAIN_EPOCH_HPP

core/vm/actor/CMakeLists.txt

@@ -3,6 +3,8 @@
 # SPDX-License-Identifier: Apache-2.0
 #
 
+add_subdirectory(builtin)
+
 add_library(actor
     account_actor.cpp
     actor.cpp
@@ -17,4 +19,5 @@ target_link_libraries(actor
     exit_code
     hamt
     power_table
+    multisig_actor
     )

core/vm/actor/actor.cpp

@@ -29,6 +29,10 @@ namespace fc::vm::actor {
            || code == kInitCodeCid || code == kCronCodeCid;
   }
 
+  bool isSignableActor(const CodeId &code) {
+    return code == kAccountCodeCid || code == kMultisigCodeCid;
+  }
+
   const CID kEmptyObjectCid{
       CID::Version::V1,
       libp2p::multi::MulticodecType::Code::DAG_CBOR,

core/vm/actor/actor.hpp

@@ -119,6 +119,9 @@ namespace fc::vm::actor {
   /** Check if only one instance of actor should exists */
   bool isSingletonActor(const CodeId &code);
 
+  /** Check if actor code can represent external signing parties */
+  bool isSignableActor(const CodeId &code);
+
   extern const CID kEmptyObjectCid;
 
   extern const CodeId kAccountCodeCid, kCronCodeCid, kStoragePowerCodeCid,

core/vm/actor/actor_method.hpp

@@ -16,7 +16,13 @@ namespace fc::vm::actor {
   using runtime::InvocationOutput;
   using runtime::Runtime;
 
-  /// Actor method signature
+  /**
+   * Actor method signature
+   * @param Actor - actor itself
+   * @param Runtime - VM context exposed to actors during method execution
+   * @param MethodParams - parameters for method call
+   * @return InvocationOutput - invocation method result or error occurred
+   */
   using ActorMethod = std::function<outcome::result<InvocationOutput>(
       const Actor &, Runtime &, const MethodParams &)>;
 
@@ -28,7 +34,7 @@ namespace fc::vm::actor {
 
   /// Decode actor params, raises appropriate error
   template <typename T>
-  outcome::result<T> decodeActorParams(gsl::span<const uint8_t> params_bytes) {
+  outcome::result<T> decodeActorParams(MethodParams params_bytes) {
     auto maybe_params = codec::cbor::decode<T>(params_bytes);
     if (!maybe_params) {
       return VMExitCode::DECODE_ACTOR_PARAMS_ERROR;
@@ -38,12 +44,12 @@ namespace fc::vm::actor {
 
   /// Encode actor params, raises appropriate error
   template <typename T>
-  outcome::result<std::vector<uint8_t>> encodeActorParams(const T &params) {
+  outcome::result<MethodParams> encodeActorParams(const T &params) {
     auto maybe_bytes = codec::cbor::encode(params);
     if (!maybe_bytes) {
       return VMExitCode::ENCODE_ACTOR_PARAMS_ERROR;
     }
-    return maybe_bytes;
+    return MethodParams{maybe_bytes.value()};
   }
 }  // namespace fc::vm::actor
 

core/vm/actor/builtin/CMakeLists.txt

@@ -0,0 +1,6 @@
+#
+# Copyright Soramitsu Co., Ltd. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+#
+
+add_subdirectory(multisig)

core/vm/actor/builtin/multisig/CMakeLists.txt

@@ -0,0 +1,12 @@
+#
+# Copyright Soramitsu Co., Ltd. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+#
+
+add_library(multisig_actor
+    multisig_actor.cpp
+    )
+target_link_libraries(multisig_actor
+    actor
+    outcome
+    )