Feature/ubsan ubuntu (#545)

* UBSAN on Ubuntu

Signed-off-by: Alexey Chernyshov <[email protected]>

Author: Alexey-N-Chernyshov

.github/workflows/ubsan-ignorelist.txt

@@ -0,0 +1,4 @@
+# Known issue in RapidJSON library
+# (https://github.com/Tencent/rapidjson/issues/1724). Waiting for the next
+# release (https://github.com/Tencent/rapidjson/issues/1006).
+src:*rapidjson/internal/stack.h

.github/workflows/ubsan.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   build:
-    runs-on: macOS-latest
+    runs-on: ubuntu-20.04
     steps:
     - uses: actions/checkout@v2
       name: checkout repo
@@ -30,21 +30,24 @@ jobs:
         git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
     - name: install
       run: |
-        echo "LIBRARY_PATH=$LIBRARY_PATH:/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib" >> $GITHUB_ENV
-        brew install ninja llvm pkg-config libb2 hwloc
+        sudo apt-get update
+        sudo apt-get install -y ninja-build python-setuptools pkg-config ocl-icd-* opencl-headers libhwloc-dev
         sudo python3 -m pip install --upgrade pip
         sudo python3 -m pip install scikit-build cmake requests gitpython gcovr pyyaml
     - name: cmake
       env:
+        CC: "clang"
+        CXX: "clang++"
+        CFLAGS: -fsanitize-blacklist=${{ github.workspace }}/.github/workflows/ubsan-ignorelist.txt
+        CXXFLAGS: -fsanitize-blacklist=${{ github.workspace }}/.github/workflows/ubsan-ignorelist.txt
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # has to be included to access other secrets
         GITHUB_HUNTER_USERNAME: ${{ secrets.HUNTER_USERNAME }}
         GITHUB_HUNTER_TOKEN: ${{ secrets.HUNTER_TOKEN }}
-        CFLAGS: "-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include"
-        CXXFLAGS: "-isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include"
       run: cmake . -GNinja -Bbuild -D UBSAN=ON -D TESTING_PROOFS=ON -D TESTING_ACTORS=ON
     - name: build
       run: cmake --build build -- -j2
     - name: run tests
       env:
         CTEST_OUTPUT_ON_FAILURE: 1
+        UBSAN_OPTIONS: "halt_on_error=1: print_stacktrace=1"
       run: cmake --build build --target test

test/core/vm/exit_code/exit_code_test.cpp

@@ -7,7 +7,9 @@
 
 #include <gtest/gtest.h>
 
-enum SampleError {};
+enum SampleError {
+  kSample = 1,
+};
 OUTCOME_HPP_DECLARE_ERROR(SampleError);
 OUTCOME_CPP_DEFINE_CATEGORY(SampleError, e) {
   return "sample error";
@@ -18,14 +20,15 @@ namespace fc::vm {
 
   /// Distinguish VMExitCode errors from other errors
   TEST(VMExitCode, IsVMExitCode) {
-    EXPECT_TRUE(isVMExitCode(failure(VMExitCode(1)).error()));
-    EXPECT_FALSE(isVMExitCode(failure(SampleError(1)).error()));
+    EXPECT_TRUE(
+        isVMExitCode(failure(VMExitCode(SampleError::kSample)).error()));
+    EXPECT_FALSE(isVMExitCode(failure(SampleError::kSample).error()));
   }
 
   /// Distinguish VMFatal errors from other errors
   TEST(VMExitCode, IsFatal) {
     EXPECT_TRUE(isFatal(failure(VMFatal(VMFatal::kFatal)).error()));
-    EXPECT_FALSE(isFatal(failure(SampleError(1)).error()));
+    EXPECT_FALSE(isFatal(failure(SampleError::kSample).error()));
   }
 
   /**
@@ -66,7 +69,7 @@ namespace fc::vm {
   TEST(VMExitCode, RequireNoErrorDefault) {
     VMExitCode default_exit_code{VMExitCode::kOk};
 
-    outcome::result<void> req{SampleError(1)};
+    outcome::result<void> req{SampleError::kSample};
     auto res = requireNoError(req, default_exit_code);
     EXPECT_TRUE(isAbortExitCode(res.error()));
     EXPECT_FALSE(isVMExitCode(res.error()));