fix proofshare log spam (#608)

* fix proofshare log spam

* proofshare: Mark tasks done when pipeline is not found

Author: magik6k

lib/proofsvc/clientctl.go

@@ -277,9 +277,9 @@ func GetProofStatus(ctx context.Context, requestCid cid.Cid) (common.ProofRespon
 			return common.ProofResponse{}, xerrors.Errorf("failed to unmarshal response body: %w", err)
 		}
 
-		// If the proof is not ready yet, return an error to trigger retry
+		// not ready yet, return empty response to the poller above
 		if proofResp.Proof == nil && proofResp.Error == "" {
-			return common.ProofResponse{}, xerrors.Errorf("proof not ready yet")
+			return common.ProofResponse{}, nil
 		}
 
 		// If there's an error in the proof generation, return it

tasks/proofshare/task_client_poll.go

@@ -146,7 +146,7 @@ func (t *TaskClientPoll) Do(taskID harmonytask.TaskID, stillOwned func() bool) (
 	}
 	if err != nil && errors.Is(err, pgx.ErrNoRows) {
 		log.Infow("client request not found", "taskID", taskID)
-		return false, nil
+		return true, nil
 	}
 
 	pollCtx, ownedCancel := context.WithCancel(ctx)
@@ -185,7 +185,7 @@ func (t *TaskClientPoll) Do(taskID harmonytask.TaskID, stillOwned func() bool) (
 
 		// check if the task is still owned
 		if !stillOwned() {
-			return false, nil
+			return false, xerrors.Errorf("yield")
 		}
 	}
 
@@ -235,7 +235,6 @@ func NewTaskClientPoll(db *harmonydb.DB, api ClientServiceAPI) *TaskClientPoll {
 
 // pollForProof polls for the proof status
 func pollForProof(ctx context.Context, db *harmonydb.DB, taskID harmonytask.TaskID, clientRequest *ClientRequest) (bool, []byte, error) {
-	log.Infow("pollForProof", "taskID", taskID, "requestCID", clientRequest.RequestCID)
 	// Parse the request CID
 	requestCid, err := cid.Parse(*clientRequest.RequestCID)
 	if err != nil {
@@ -245,7 +244,6 @@ func pollForProof(ctx context.Context, db *harmonydb.DB, taskID harmonytask.Task
 	// Get proof status by CID
 	proofResp, err := proofsvc.GetProofStatus(ctx, requestCid)
 	if err != nil || proofResp.Proof == nil {
-		log.Infow("proof not ready", "taskID", taskID, "spID", clientRequest.SpID, "sectorNumber", clientRequest.SectorNumber)
 		// Not ready yet, continue polling
 		return false, nil, nil
 	}

tasks/proofshare/task_client_upload.go

@@ -63,6 +63,10 @@ func (t *TaskClientUpload) Do(taskID harmonytask.TaskID, stillOwned func() bool)
 	if err != nil && !errors.Is(err, pgx.ErrNoRows) {
 		return false, xerrors.Errorf("failed to get client request: %w", err)
 	}
+	if err != nil && errors.Is(err, pgx.ErrNoRows) {
+		log.Infow("client upload not found", "taskID", taskID)
+		return true, nil
+	}
 
 	if clientRequest.RequestSent && len(clientRequest.ResponseData) > 0 {
 		// special case: pipeline was done but re-entered due to the retry button on the PrRep page being clicked