release v1.27.0 (#627)

* release v1.27.0

* fix lint issues

* docker go version bump

Author: LexLuthr

.github/image/Dockerfile

@@ -1,6 +1,6 @@
 ## This image is used to github action runner for this repo
 # Use the official Golang image as the base image
-FROM golang:1.23-bullseye AS builder
+FROM golang:1.24-bullseye AS builder
 
 # Set the working directory inside the container
 WORKDIR /app
@@ -23,7 +23,7 @@ RUN git submodule update --init
 RUN go mod download
 
 # Stage 2: Install Lotus binary
-FROM ghcr.io/filecoin-shipyard/lotus-containers:lotus-v1.33.1-devnet AS lotus-test
+FROM ghcr.io/filecoin-shipyard/lotus-containers:lotus-v1.34.0-rc2-devnet AS lotus-test
 
 # Stage 3: Build the final image
 FROM myoung34/github-runner AS curio-github-runner

.github/workflows/ci.yml

@@ -9,7 +9,7 @@ on:
       - '**'
 
 env:
-  GO_VERSION: 1.23
+  GO_VERSION: 1.24
 
 jobs:
   ci-lint:
@@ -257,7 +257,7 @@ jobs:
 
       - name: Install golangci-lint
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.1
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.4.0
         shell: bash
 
       - name: Lint

Dockerfile

@@ -1,7 +1,7 @@
 #####################################
 ARG LOTUS_TEST_IMAGE=curio/lotus-all-in-one:latest
 FROM ${LOTUS_TEST_IMAGE} AS lotus-test
-FROM golang:1.23-bullseye AS curio-builder
+FROM golang:1.24-bullseye AS curio-builder
 LABEL Maintainer="Curio Development Team"
 
 RUN apt-get update && apt-get install -y ca-certificates build-essential clang ocl-icd-opencl-dev ocl-icd-libopencl1 jq libhwloc-dev
@@ -48,7 +48,7 @@ ARG CURIO_TAGS=""
 RUN make build
 
 ####################################
-FROM golang:1.23-bullseye AS piece-server-builder
+FROM golang:1.24-bullseye AS piece-server-builder
 
 RUN go install github.com/ipld/go-car/cmd/car@latest \
  && cp $GOPATH/bin/car /usr/local/bin/

GO_VERSION_MIN

@@ -1 +1 @@
-1.23
+1.24

Makefile

@@ -279,7 +279,7 @@ build_lotus?=0
 curio_docker_user?=curio
 curio_base_image=$(curio_docker_user)/curio-all-in-one:latest-debug
 ffi_from_source?=0
-lotus_version?=v1.33.1
+lotus_version?=v1.34.0-rc2
 
 ifeq ($(build_lotus),1)
 # v1: building lotus image with provided lotus version

cmd/curio/cli.go

@@ -229,10 +229,7 @@ var waitApiCmd = &cli.Command{
 		ctx := reqcontext.ReqContext(cctx)
 		ctx, cancel := context.WithTimeout(ctx, cctx.Duration("timeout"))
 		defer cancel()
-		for {
-			if ctx.Err() != nil {
-				break
-			}
+		for ctx.Err() == nil {
 
 			api, closer, err := rpc.GetCurioAPI(cctx)
 			if err != nil {

cmd/curio/debug-ipni.go

@@ -26,7 +26,9 @@ var testDebugIpniChunks = &cli.Command{
 		if err != nil {
 			return xerrors.Errorf("opening file: %w", err)
 		}
-		defer f.Close()
+		defer func() {
+			_ = f.Close()
+		}()
 
 		opts := []carv2.Option{carv2.ZeroLengthSectionAsEOF(true)}
 		blockReader, err := carv2.NewBlockReader(bufio.NewReaderSize(f, 4<<20), opts...)
@@ -36,7 +38,7 @@ var testDebugIpniChunks = &cli.Command{
 
 		blockMetadata, err := blockReader.SkipNext()
 		for err == nil {
-			if err := ck.Accept(blockMetadata.Cid.Hash(), int64(blockMetadata.Offset), blockMetadata.Size+40); err != nil {
+			if err := ck.Accept(blockMetadata.Hash(), int64(blockMetadata.Offset), blockMetadata.Size+40); err != nil {
 				return xerrors.Errorf("accepting block: %w", err)
 			}
 

cmd/curio/debug-snsvc.go

@@ -590,7 +590,7 @@ func getClientStateAction(cctx *cli.Context) error {
 	fmt.Printf("VoucherRedeemed: %s\n", types.FIL(clientState.VoucherRedeemed).String())
 	fmt.Printf("LastNonce: %d\n", clientState.LastNonce)
 	fmt.Printf("WithdrawAmount: %s\n", types.FIL(clientState.WithdrawAmount).String())
-	ts := clientState.WithdrawTimestamp.Int.Uint64()
+	ts := clientState.WithdrawTimestamp.Uint64()
 	wt := time.Unix(int64(ts), 0)
 	diff := time.Until(wt)
 	var diffStr string

cmd/curio/guidedsetup/guidedsetup.go

@@ -37,7 +37,6 @@ import (
 	"github.com/filecoin-project/curio/api"
 	"github.com/filecoin-project/curio/build"
 	"github.com/filecoin-project/curio/cmd/curio/internal/translations"
-	_ "github.com/filecoin-project/curio/cmd/curio/internal/translations"
 	"github.com/filecoin-project/curio/deps"
 	"github.com/filecoin-project/curio/deps/config"
 	"github.com/filecoin-project/curio/harmony/harmonydb"
@@ -163,9 +162,10 @@ func newOrMigrate(d *MigrationData) {
 		d.say(notice, "Aborting remaining steps.", err.Error())
 		os.Exit(1)
 	}
-	if i == 1 {
+	switch i {
+	case 1:
 		d.init = true
-	} else if i == 2 {
+	case 2:
 		d.nonSP = true
 	}
 }

cmd/curio/main.go

@@ -240,7 +240,7 @@ func runApp(app *cli.App) {
 		if os.Getenv("LOTUS_DEV") != "" {
 			log.Warnf("%+v", err)
 		} else {
-			fmt.Fprintf(os.Stderr, "ERROR: %s\n\n", err) // nolint:errcheck
+			_, _ = fmt.Fprintf(os.Stderr, "ERROR: %s\n\n", err) // nolint:errcheck
 		}
 
 		var phe *PrintHelpErr