Merge pull request #37 from filecoin-project/fix/defer-panic

travisperson · web-flow · commit 774515db7af2 · 2022-07-12T09:53:12.000Z
fix: panic on exit from nil defer
diff --git a/cmd/filecoin-chain-archiver/cmds/create.go b/cmd/filecoin-chain-archiver/cmds/create.go
@@ -173,10 +173,11 @@ var cmdCreate = &cli.Command{
 			if err != nil {
 				if errors.Is(err, syscall.ECONNREFUSED) {
 					logger.Warnw("failed to dial node", "err", err)
-					continue
+				} else {
+					logger.Warnw("failed to create node client", "err", err)
 				}
 
-				logger.Warnw("failed to create node client", "err", err)
+				continue
 			}
 
 			defer closer()

Original file line number	Diff line number	Diff line change
`@@ -173,10 +173,11 @@ var cmdCreate = &cli.Command{`
`173`	`173`	`if err != nil {`
`174`	`174`	`if errors.Is(err, syscall.ECONNREFUSED) {`
`175`	`175`	`logger.Warnw("failed to dial node", "err", err)`
`176`		`- continue`
	`176`	`+ } else {`
	`177`	`+ logger.Warnw("failed to create node client", "err", err)`
`177`	`178`	`}`
`178`	`179`
`179`		`- logger.Warnw("failed to create node client", "err", err)`
	`180`	`+ continue`
`180`	`181`	`}`
`181`	`182`
`182`	`183`	`defer closer()`