fix: pieces can be removed from a data-set #253
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilOzzy
added
team/filecoin-pin
Copilot finished reviewing on behalf of
SgtPooki
November 19, 2025 18:35
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new rm command to the CLI that enables users to remove pieces from data sets via the Synapse SDK. The implementation follows established patterns from similar commands (add, import) and provides both CLI and library usage patterns through a flexible API design.
Key changes:
- New
rmcommand with options for piece CID, data set ID, and optional transaction confirmation - Core
removePiecefunction supporting both CLI (with dataSetId) and library (with StorageContext) usage patterns - Progress event system for tracking transaction submission and confirmation
- Package export for the new
core/piecemodule
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/commands/rm.ts |
Defines the CLI command interface with piece, data-set, and wait-for-confirmation options |
src/rm/types.ts |
TypeScript interfaces for rm command options and results |
src/rm/remove-piece.ts |
CLI orchestration layer with input validation, Synapse initialization, and progress tracking |
src/rm/index.ts |
Export file for rm module |
src/core/piece/remove-piece.ts |
Reusable core function for removing pieces with flexible API supporting both CLI and library usage |
src/core/piece/index.ts |
Export file for core piece module |
src/cli.ts |
Registers the new rm command with the main CLI program |
package.json |
Adds package export entry for the new core/piece module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
rmcommand to CLI. This command will remove a piece from a data set.Usage
Options
--piece <cid>: The CID of the piece to remove.--data-set <id>: The ID of the data set to remove the piece from.--wait-for-confirmation: Wait for transaction confirmation before exiting.still in draft because data-set show and rm are conflicting somewhere. See https://filecoinproject.slack.com/archives/C095WFA0QK1/p1763576428763319