feat: test upload-action in ci. closes #395#399
Conversation
FilOzzy
added
team/filecoin-pin
| push: | ||
| pull_request: | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
I considered using a matrix for the very similar upload and dry-run jobs, but overall it was simpler without, and the repeated code isn't much at all
There was a problem hiding this comment.
Maybe leave that as a comment in the file itself?
# Intentionally not using a `matrix` for simplicity. The repeated code isn't much. The only difference is `dryRun`.
Just so there is a siganl for someone that "yeah, these are basically the same except for dry run true and false.
And maybe to drive that home we have dryRune: false under upload?
* fix upload-action: pnpm needs to be installed before node * check if disabling the cache fixes it * use `package_json_file` * try this * add back cache * fix path
|
Getting upload to work is blocked by https://stg.usdfc.net/#/ failing to load for me |
|
cherry picked https://github.com/filecoin-project/filecoin-pin/pull/400/commits to verify everything works in integration |
BigLep
left a comment
BigLep
left a comment
There was a problem hiding this comment.
@juliangruber : is this still blocked? Lets mark it for review when ready. We can assign Russell.
There was a problem hiding this comment.
rename to test-upload-action.yml to make it clear that this is about testing the upload action rather than relying on the upload action?
| push: | ||
| pull_request: | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Maybe leave that as a comment in the file itself?
# Intentionally not using a `matrix` for simplicity. The repeated code isn't much. The only difference is `dryRun`.
Just so there is a siganl for someone that "yeah, these are basically the same except for dry run true and false.
And maybe to drive that home we have dryRune: false under upload?
| uses: ./upload-action | ||
| with: | ||
| path: ./src | ||
| walletPrivateKey: ${{ secrets.WALLET_PRIVATE_KEY }} |
There was a problem hiding this comment.
What wallet is this for? Was a new wallet set up? I want to make sure this is documented (at the minimum stored in FilOz 1password)?
Probalby should use the same wallet as https://github.com/filecoin-project/filecoin-pin-website/settings/secrets/actions
|
This isn't ready for review yet because it's not working. Which is a great thing, the new CI action is verifying itself and failing. I haven't yet found time to fix this, as I'm moving to Pay Explorer. I'm happy for someone to take this over |
4 participants
Closes #395
Blocked #399 (comment)