Merge pull request #126 from filecoin-project/feat/config-defaults

Defaults - environment variables config file

Author: clriesco

fplus-lib/Cargo.toml

@@ -29,4 +29,5 @@ tokio = { version = "1.32.0", features = ["rt", "macros"] }
 uuidv4 = "1.0.0"
 rayon = "1.8.0"
 log = "0.4.20"
+once_cell = "1.19.0"
 fplus-database = { path = "../fplus-database", version = "1.0.19"}

fplus-lib/src/config.rs

@@ -1,11 +1,34 @@
 use log::warn;
+use std::collections::HashMap;
+use once_cell::sync::OnceCell;
 
-pub fn get_env_var_or_default(key: &str, default: &str) -> String {
+pub fn default_env_vars() -> &'static HashMap<&'static str, &'static str> {
+    static DEFAULTS: OnceCell<HashMap<&'static str, &'static str>> = OnceCell::new();
+    DEFAULTS.get_or_init(|| {
+        let mut m = HashMap::new();
+        m.insert("GITHUB_OWNER", "filecoin-project");
+        m.insert("GITHUB_REPO", "filecoin-plus-falcon");
+        m.insert("GITHUB_APP_ID", "826129");
+        m.insert("GITHUB_INSTALLATION_ID", "47207972");
+        m.insert("RUST_LOG", "info");
+        m.insert("RUST_BACKTRACE", "1");
+        m.insert("DB_URL", "");
+        m.insert("ALLOCATOR_GOVERNANCE_REPO", "Allocator-Governance-Staging");
+        m.insert("ALLOCATOR_GOVERNANCE_OWNER", "fidlabs");
+        m.insert("BOT_USER", "filplus-allocators-staging-bot[bot]");
+        
+        m
+    })
+}
+
+pub fn get_env_var_or_default(key: &str) -> String {
     match std::env::var(key) {
         Ok(val) => val,
         Err(_) => {
+            let defaults = default_env_vars();
+            let default = defaults.get(key).unwrap_or(&"");
             warn!("{} not set, using default value: {}", key, default);
             default.to_string()
         }
     }
-}
+}

fplus-lib/src/core/mod.rs

@@ -855,7 +855,7 @@ impl LDNApplication {
             log::info!("- Application is in a valid state!");
             return Ok(true);
         }
-        let bot_user = get_env_var_or_default("BOT_USER", "filplus-allocators-staging-bot[bot]");
+        let bot_user = get_env_var_or_default("BOT_USER");
         if author != bot_user {
             log::warn!("- Author is not the bot user");
             return Ok(false);
@@ -883,7 +883,7 @@ impl LDNApplication {
             let app_state = application_file.lifecycle.get_state();
             let active_request_id = application_file.lifecycle.active_request.clone();
             let valid_verifier_list = Self::fetch_verifiers(owner.clone(), repo.clone()).await?;
-            let bot_user = get_env_var_or_default("BOT_USER", "filplus-allocators-staging-bot[bot]");
+            let bot_user = get_env_var_or_default("BOT_USER");
 
             let res: bool = match app_state {
                 AppState::Submitted => {

fplus-lib/src/external_services/github.rs

@@ -88,22 +88,21 @@ struct Author {
 
 impl GithubWrapper {
     pub fn new(owner: String, repo: String) -> Self {
-        let app_id = get_env_var_or_default("GITHUB_APP_ID", "826129")
-            .parse::<u64>()
-            .unwrap_or_else(|_| {
-                log::error!("Failed to parse GITHUB_APP_ID, using default");
-                826129
-            });
-        let installation_id = get_env_var_or_default("GITHUB_INSTALLATION_ID", "47207972")
-            .parse::<u64>()
-            .unwrap_or_else(|_| {
-                log::error!("Failed to parse GITHUB_INSTALLATION_ID, using default");
-                47207972
-            });
+        let app_id_str = get_env_var_or_default("GITHUB_APP_ID");
+        let installation_id_str = get_env_var_or_default("GITHUB_INSTALLATION_ID");
+    
+        let app_id = app_id_str.parse::<u64>().unwrap_or_else(|_| {
+            log::error!("Failed to parse GITHUB_APP_ID as u64, using default value");
+            0
+        });
+    
+        let installation_id = installation_id_str.parse::<u64>().unwrap_or_else(|_| {
+            log::error!("Failed to parse GITHUB_INSTALLATION_ID as u64, using default value");
+            0
+        });
+    
         let gh_private_key = std::env::var("GH_PRIVATE_KEY").unwrap_or_else(|_| {
-            log::warn!(
-                "GH_PRIVATE_KEY not found in .env file, attempting to read from gh-private-key.pem"
-            );
+            log::warn!("GH_PRIVATE_KEY not found in .env file, attempting to read from gh-private-key.pem");
             std::fs::read_to_string("gh-private-key.pem").unwrap_or_else(|e| {
                 log::error!("Failed to read gh-private-key.pem. Error: {:?}", e);
                 std::process::exit(1);