refactor: simplify graphsync transport (#203)

* refactor: simplify graphsync transport

* feat: add more logging to graphsync transport

* refactor: keep gs req fields in one struct

Author: dirkmc

impl/impl.go

@@ -397,7 +397,7 @@ func (m *manager) ResumeDataTransferChannel(ctx context.Context, chid datatransf
 
 	err := pausable.ResumeChannel(ctx, m.resumeMessage(chid), chid)
 	if err != nil {
-		log.Warnf("Error attempting to pause at transport level: %s", err.Error())
+		log.Warnf("Error attempting to resume at transport level: %s", err.Error())
 	}
 
 	return m.resume(chid)

impl/integration_test.go

@@ -727,7 +727,7 @@ func TestAutoRestart(t *testing.T) {
 				AcceptTimeout:          100 * time.Millisecond,
 				RestartDebounce:        500 * time.Millisecond,
 				RestartBackoff:         500 * time.Millisecond,
-				MaxConsecutiveRestarts: 5,
+				MaxConsecutiveRestarts: 10,
 				RestartAckTimeout:      100 * time.Millisecond,
 				CompleteTimeout:        100 * time.Millisecond,
 			})

impl/receiver.go

@@ -131,19 +131,19 @@ func (r *receiver) ReceiveRestartExistingChannelRequest(ctx context.Context,
 
 	// initiator should be me
 	if channel.ChannelID().Initiator != r.manager.peerID {
-		log.Error("cannot restart channel %s: channel initiator is not the manager peer", ch)
+		log.Errorf("cannot restart channel %s: channel initiator is not the manager peer", ch)
 		return
 	}
 
 	// other peer should be the counter party on the channel
 	if channel.OtherPeer() != sender {
-		log.Error("cannot restart channel %s: channel counterparty is not the sender peer", ch)
+		log.Errorf("cannot restart channel %s: channel counterparty is not the sender peer", ch)
 		return
 	}
 
 	// channel should NOT be terminated
 	if channels.IsChannelTerminated(channel.Status()) {
-		log.Error("cannot restart channel %s: channel already terminated", ch)
+		log.Errorf("cannot restart channel %s: channel already terminated", ch)
 		return
 	}