cleanup: remove handling of SigningMarshaler from f3 (#923)

Signed-off-by: Jakub Sztandera <[email protected]>

Author: Kubuxu

cmd/f3/run.go

@@ -193,11 +193,3 @@ func setupDiscovery(h host.Host) (closer func(), err error) {
 type fakeSigner struct {
 	signing.FakeBackend
 }
-
-// MarshalPayloadForSigning marshals the given payload into the bytes that should be signed.
-// This should usually call `Payload.MarshalForSigning(NetworkName)` except when testing as
-// that method is slow (computes a merkle tree that's necessary for testing).
-// Implementations must be safe for concurrent use.
-func (fs *fakeSigner) MarshalPayloadForSigning(nn gpbft.NetworkName, p *gpbft.Payload) []byte {
-	return p.MarshalForSigning(nn)
-}

gpbft/api.go

@@ -128,6 +128,7 @@ type SigningMarshaler interface {
 	// This should usually call `Payload.MarshalForSigning(NetworkName)` except when testing as
 	// that method is slow (computes a merkle tree that's necessary for testing).
 	// Implementations must be safe for concurrent use.
+	// WARNING: the partial message code depends on the structure of signed payload
 	MarshalPayloadForSigning(NetworkName, *Payload) []byte
 }
 

host.go

@@ -838,14 +838,9 @@ func (h *gpbftHost) saveDecision(decision *gpbft.Justification) (*certs.Finality
 }
 
 // MarshalPayloadForSigning marshals the given payload into the bytes that should be signed.
-// This should usually call `Payload.MarshalForSigning(NetworkName)` except when testing as
-// that method is slow (computes a merkle tree that's necessary for testing).
+// This calls `Payload.MarshalForSigning(NetworkName)`
 func (h *gpbftHost) MarshalPayloadForSigning(nn gpbft.NetworkName, p *gpbft.Payload) []byte {
-	if m, ok := h.verifier.(gpbft.SigningMarshaler); ok {
-		return m.MarshalPayloadForSigning(nn, p)
-	} else {
-		return p.MarshalForSigning(nn)
-	}
+	return p.MarshalForSigning(nn)
 }
 
 // Verifies a signature for the given public key.