Merge pull request #37 from ipfs/feat/ser-errs

add special errors for denoting serialization issues

Author: whyrusleeping

go.mod

@@ -10,3 +10,5 @@ require (
 	github.com/whyrusleeping/cbor-gen v0.0.0-20190910031516-c1cbffdb01bb
 	golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
 )
+
+go 1.13

hamt_test.go

@@ -273,6 +273,45 @@ func TestBasic(t *testing.T) {
 	}
 }
 
+func TestDelete(t *testing.T) {
+	ctx := context.Background()
+	cs := NewCborStore()
+	begn := NewNode(cs)
+
+	val := []byte("cat dog bear")
+	if err := begn.Set(ctx, "foo", val); err != nil {
+		t.Fatal(err)
+	}
+
+	for i := 0; i < 10; i++ {
+		if err := begn.Set(ctx, randString(), randValue()); err != nil {
+			t.Fatal(err)
+		}
+	}
+
+	if err := begn.Flush(ctx); err != nil {
+		t.Fatal(err)
+	}
+	c, err := cs.Put(ctx, begn)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	n, err := LoadNode(ctx, cs, c)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if err := n.Delete(ctx, "foo"); err != nil {
+		t.Fatal(err)
+	}
+
+	var out []byte
+	if err := n.Find(ctx, "foo", &out); err == nil {
+		t.Fatal("shouldnt have found object")
+	}
+}
+
 func TestSetGet(t *testing.T) {
 	ctx := context.Background()
 	vals := make(map[string][]byte)

ipld.go

@@ -50,6 +50,22 @@ type CborIpldStore struct {
 	Atlas  *atlas.Atlas
 }
 
+func NewSerializationError(err error) error {
+	return SerializationError{err}
+}
+
+type SerializationError struct {
+	err error
+}
+
+func (se SerializationError) Error() string {
+	return se.err.Error()
+}
+
+func (se SerializationError) Unwrap() error {
+	return se.err
+}
+
 type blocks interface {
 	GetBlock(context.Context, cid.Cid) (block.Block, error)
 	AddBlock(block.Block) error
@@ -114,7 +130,11 @@ func (s *CborIpldStore) Get(ctx context.Context, c cid.Cid, out interface{}) err
 
 	cu, ok := out.(cbg.CBORUnmarshaler)
 	if ok {
-		return cu.UnmarshalCBOR(bytes.NewReader(blk.RawData()))
+		if err := cu.UnmarshalCBOR(bytes.NewReader(blk.RawData())); err != nil {
+			return NewSerializationError(err)
+		}
+
+		return nil
 	}
 
 	if s.Atlas == nil {
@@ -146,7 +166,7 @@ func (s *CborIpldStore) Put(ctx context.Context, v interface{}) (cid.Cid, error)
 	if ok {
 		buf := new(bytes.Buffer)
 		if err := cm.MarshalCBOR(buf); err != nil {
-			return cid.Undef, err
+			return cid.Undef, NewSerializationError(err)
 		}
 
 		pref := cid.Prefix{