fix: potential race when reading incomingErr #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=========================================
Coverage ? 71.49%
=========================================
Files ? 12
Lines ? 1968
Branches ? 0
=========================================
Hits ? 1407
Misses ? 460
Partials ? 101
|
Stebalien
approved these changes
Jan 8, 2025
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
Feels like there should be a better way but this is definitely the safest approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @parthshah1, discovered via Antithesis. A client is able to get itself into a state where there's a race in accessing
incomingErr, so we'll lock it just to be safe.