Skip to content

Commit 4e45acf

Browse files
firesWurvagg
authored andcommitted
fix: market: use expiry-activation for deal weight calculation
Ref: #237
1 parent 345ace6 commit 4e45acf

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

builtin/v13/market/market_state.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ func validateAndComputeDealWeight(proposals *DealArray, dealIDs []abi.DealID, mi
194194

195195
// Compute deal weight
196196
totalDealSpace += uint64(proposal.PieceSize)
197-
dealSpaceTime := DealWeight(proposal)
197+
dealSpaceTime := DealWeight(proposal, sectorExpiry, sectorActivation)
198198
if proposal.VerifiedDeal {
199199
totalVerifiedSpaceTime = big.Add(totalVerifiedSpaceTime, dealSpaceTime)
200200
} else {

builtin/v13/market/policy.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ func DealClientCollateralBounds(_ abi.PaddedPieceSize, _ abi.ChainEpoch) (min ab
5555
}
5656

5757
// Computes the weight for a deal proposal, which is a function of its size and duration.
58-
func DealWeight(proposal *DealProposal) abi.DealWeight {
59-
dealDuration := big.NewInt(int64(proposal.Duration()))
58+
func DealWeight(proposal *DealProposal, sectorExpiry abi.ChainEpoch, sectorActivation abi.ChainEpoch) abi.DealWeight {
59+
dealDuration := big.NewInt(int64(sectorExpiry - sectorActivation))
6060
dealSize := big.NewIntUnsigned(uint64(proposal.PieceSize))
6161
dealSpaceTime := big.Mul(dealDuration, dealSize)
6262
return dealSpaceTime

builtin/v14/market/market_state.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ func validateAndComputeDealWeight(proposals *DealArray, dealIDs []abi.DealID, mi
194194

195195
// Compute deal weight
196196
totalDealSpace += uint64(proposal.PieceSize)
197-
dealSpaceTime := DealWeight(proposal)
197+
dealSpaceTime := DealWeight(proposal, sectorExpiry, sectorActivation)
198198
if proposal.VerifiedDeal {
199199
totalVerifiedSpaceTime = big.Add(totalVerifiedSpaceTime, dealSpaceTime)
200200
} else {

builtin/v14/market/policy.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ func DealClientCollateralBounds(_ abi.PaddedPieceSize, _ abi.ChainEpoch) (min ab
5555
}
5656

5757
// Computes the weight for a deal proposal, which is a function of its size and duration.
58-
func DealWeight(proposal *DealProposal) abi.DealWeight {
59-
dealDuration := big.NewInt(int64(proposal.Duration()))
58+
func DealWeight(proposal *DealProposal, sectorExpiry abi.ChainEpoch, sectorActivation abi.ChainEpoch) abi.DealWeight {
59+
dealDuration := big.NewInt(int64(sectorExpiry - sectorActivation))
6060
dealSize := big.NewIntUnsigned(uint64(proposal.PieceSize))
6161
dealSpaceTime := big.Mul(dealDuration, dealSize)
6262
return dealSpaceTime

0 commit comments

Comments
 (0)