fix: add missing span.End() (#1202)

birdychang · web-flow · commit 0c54ee4d6a98 · 2023-05-11T11:11:09.000-07:00
diff --git a/tasks/blocks/drand/task.go b/tasks/blocks/drand/task.go
@@ -28,6 +28,7 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "blocks"),
 		)
 	}
+	defer span.End()
 
 	var pl model.PersistableList
 	for _, bh := range ts.Blocks() {
diff --git a/tasks/blocks/headers/task.go b/tasks/blocks/headers/task.go
@@ -28,6 +28,7 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "blocks"),
 		)
 	}
+	defer span.End()
 
 	var pl model.PersistableList
 	for _, bh := range ts.Blocks() {
diff --git a/tasks/blocks/parents/task.go b/tasks/blocks/parents/task.go
@@ -28,6 +28,7 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "blocks"),
 		)
 	}
+	defer span.End()
 
 	var pl model.PersistableList
 	for _, bh := range ts.Blocks() {
diff --git a/tasks/fevmactorstats/task.go b/tasks/fevmactorstats/task.go
@@ -43,6 +43,8 @@ func (p *Task) ProcessTipSet(ctx context.Context, ts *types.TipSet) (model.Persi
 			attribute.String("processor", "fevmactorstats"),
 		)
 	}
+	defer span.End()
+
 	report := &visormodel.ProcessingReport{
 		Height:    int64(ts.Height()),
 		StateRoot: ts.ParentState().String(),
diff --git a/tasks/messages/blockmessage/task.go b/tasks/messages/blockmessage/task.go
@@ -26,7 +26,7 @@ func NewTask(node tasks.DataSource) *Task {
 }
 
 func (t *Task) ProcessTipSet(ctx context.Context, current *types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")
+	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")
 	if span.IsRecording() {
 		span.SetAttributes(
 			attribute.String("current", current.String()),
diff --git a/tasks/messages/gaseconomy/task.go b/tasks/messages/gaseconomy/task.go
@@ -29,7 +29,7 @@ func NewTask(node tasks.DataSource) *Task {
 }
 
 func (t *Task) ProcessTipSet(ctx context.Context, current *types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")
+	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")
 	if span.IsRecording() {
 		span.SetAttributes(
 			attribute.String("current", current.String()),
diff --git a/tasks/messages/message/task.go b/tasks/messages/message/task.go
@@ -27,7 +27,7 @@ func NewTask(node tasks.DataSource) *Task {
 }
 
 func (t *Task) ProcessTipSet(ctx context.Context, current *types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")
+	ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")
 	if span.IsRecording() {
 		span.SetAttributes(
 			attribute.String("current", current.String()),

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ func (p Task) ProcessTipSet(ctx context.Context, ts types.TipSet) (model.Persi`
`28`	`28`	`attribute.String("processor", "blocks"),`
`29`	`29`	`)`
`30`	`30`	`}`
	`31`	`+ defer span.End()`
`31`	`32`
`32`	`33`	`var pl model.PersistableList`
`33`	`34`	`for _, bh := range ts.Blocks() {`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,8 @@ func (p Task) ProcessTipSet(ctx context.Context, ts types.TipSet) (model.Persi`
`43`	`43`	`attribute.String("processor", "fevmactorstats"),`
`44`	`44`	`)`
`45`	`45`	`}`
	`46`	`+ defer span.End()`
	`47`	`+`
`46`	`48`	`report := &visormodel.ProcessingReport{`
`47`	`49`	`Height: int64(ts.Height()),`
`48`	`50`	`StateRoot: ts.ParentState().String(),`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ func NewTask(node tasks.DataSource) *Task {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`func (t Task) ProcessTipSet(ctx context.Context, current types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {`
`29`		`- ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")`
	`29`	`+ ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")`
`30`	`30`	`if span.IsRecording() {`
`31`	`31`	`span.SetAttributes(`
`32`	`32`	`attribute.String("current", current.String()),`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func NewTask(node tasks.DataSource) *Task {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`func (t Task) ProcessTipSet(ctx context.Context, current types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {`
`32`		`- ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")`
	`32`	`+ ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")`
`33`	`33`	`if span.IsRecording() {`
`34`	`34`	`span.SetAttributes(`
`35`	`35`	`attribute.String("current", current.String()),`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ func NewTask(node tasks.DataSource) *Task {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`func (t Task) ProcessTipSet(ctx context.Context, current types.TipSet) (model.Persistable, *visormodel.ProcessingReport, error) {`
`30`		`- ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSets")`
	`30`	`+ ctx, span := otel.Tracer("").Start(ctx, "ProcessTipSet")`
`31`	`31`	`if span.IsRecording() {`
`32`	`32`	`span.SetAttributes(`
`33`	`33`	`attribute.String("current", current.String()),`