Skip to content

Commit 1f1afe5

Browse files
BigLeprjan90
andauthored
docs(release): v1.29.2 release template improvements (#12479)
* Update RELEASE_ISSUE_TEMPLATE.md * chore: add example title in release issue template chore: add example title in release issue template --------- Co-authored-by: Phi <[email protected]>
1 parent c674554 commit 1f1afe5

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

documentation/misc/RELEASE_ISSUE_TEMPLATE.md

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,22 @@
44
[//]: # (❗️ Complete the steps below as part of creating a release issue and mark them complete with an X or ✅ when done.)
55
[//]: # ([ ] Start an issue with title "[WIP] Lotus Node|Miner vX.Y.Z Release" and adjust the title for whether it's a Node or Miner release.)
66
[//]: # ([ ] Copy in the content of https://github.com/filecoin-project/lotus/blob/master/documentation/misc/RELEASE_ISSUE_TEMPLATE.md)
7-
[//]: # ([ ] Find/Replace "X.Y.(Z+1)" with the actual values (e.g., v1.30.1).
8-
[//]: # ([ ] Find/Replace "X.Y.Z" with the actual values.
7+
[//]: # ([ ] Find/Replace "X.Y.\(Z+1\)" with the actual values e.g., v1.30.1)
8+
[//]: # ([ ] Find/Replace "X.Y.Z" with the actual values)
99
[//]: # ([ ] If this isn't a release tied to a network upgrade, remove all items with "\(network upgrade\)")
1010
[//]: # ([ ] If this is a patch release, remove all items with "\(minor release\)")
1111
[//]: # ([ ] If this is a minor release, remove all items with "\(patch release\)")
1212
[//]: # ([ ] Copy/paste the "Release Checklist > rcX" section to "Release Checklist > Stable \(non-RC\) Release" and apply the "diff" called out there.)
13-
[//]: # ([ ] Find/Replace "rcX" with "rc1".)
14-
[//]: # ([ ] Adjust the "Meta" section values.)
13+
[//]: # ([ ] Find/Replace "rcX" with "rc1")
14+
[//]: # ([ ] Adjust the "Meta" section values)
1515
[//]: # ([ ] Apply the `tpm` label to the issue)
1616
[//]: # ([ ] Create the issue)
1717
[//]: # ([ ] Pin the issue on GitHub)
1818

1919
## 😶‍🌫 Meta
2020
* Scope: Node|Miner MINOR|PATCH
2121
* Is this linked with a network upgrade, and thus mandatory? Yes|No
22-
* Related network upgrade version: nvXX|n/a
22+
* (network upgrade) Related network upgrade version: nvXX
2323
* (network upgrade) Scope, dates, and epochs: <link to post in https://github.com/filecoin-project/community/discussions/74>
2424
* (network upgrade) Lotus changelog with Lotus specifics: <link to section in https://github.com/filecoin-project/lotus/blob/master/CHANGELOG.md with more details>
2525

@@ -58,12 +58,13 @@
5858
- [ ] (patch release) Fork a new branch (`release/vX.Y.Z` or `release/miner/vX.Y.Z`) from the last stable `release/vX.Y.x` or `release/miner/vX.Y.x` and make any further release-related changes to this branch.
5959
- [ ] (minor release) Fork a new branch (`release/vX.Y.Z` or `release/miner/vX.Y.Z`) from `master` and make any further release-related changes to this branch.
6060
- `master` branch Version string updates
61-
- Skip this set of steps if you are patching a previos minor release.
61+
- Skip this set of steps if you are patching a previous minor release.
6262
- [ ] bump the version(s) in `build/version.go` to `vX.Y.(Z+1)-dev`.
6363
- Ensure to update the appropriate version string based on whether you are creating a node release (`NodeBuildVersion`), a miner release (`MinerBuildVersion`), or both.
6464
- [ ] Run `make gen && make docsgen-cli` before committing changes.
6565
- [ ] Update the CHANGELOG
66-
- [ ] Change the `UNRELEASED` section to `UNRELEASED vX.Y.Z` and set the section's content to be `See https://github.com/filecoin-project/lotus/blob/release/vX.Y.Z/CHANGELOG.md`
66+
- [ ] Change the `UNRELEASED` section header to `UNRELEASED vX.Y.Z`
67+
- [ ] Set the `UNRELEASED vX.Y.Z` section's content to be "_See https://github.com/filecoin-project/lotus/blob/release/vX.Y.Z/CHANGELOG.md_"
6768
- [ ] Add a new `UNRELEASED` header to top.
6869
- [ ] Create a PR with title `build: update Lotus Node|Miner version to vX.Y.(Z+1)-dev in master`
6970
- Link to PR:
@@ -130,15 +131,15 @@
130131
> 1. Release PR > Update the version string...
131132
> * Update the version string in `build/version.go` to one **NOT** ending with '-rcX'
132133
> 2. Release PR > Changelog prep...
133-
> * Add `(network upgrade) Ensure the Mainnet upgrade epoch is specified.`
134-
> 3. Release PR > Update the version string...
135-
> * Create a PR with title `build: release vX.Y.Z`
134+
> * Add "(network upgrade) Ensure the Mainnet upgrade epoch is specified."
135+
> 3. Release PR > Create a draft PR...
136+
> * Create a PR with title `build: release Lotus node|miner vX.Y.Z`
136137
>
137138
> 3️⃣ Remove this `[!Note]` and the related invisible comments.
138139
139140
### Post-Release
140141

141-
- [ ] Open a pull request against `master` cherry-picking the CHANGELOG commits from the `release/vX.Y.Z` branch.
142+
- [ ] Open a PR against `master` cherry-picking the CHANGELOG commits from the `release/vX.Y.Z` branch. Title it `chore(release): cherry-pick vX.Y.Z changelog back to master`
142143
- Link to PR:
143144
- Assuming we followed [the process of merging changes into `master` first before backporting to the release branch](https://github.com/filecoin-project/lotus/blob/master/LOTUS_RELEASE_FLOW.md#branch-and-tag-strategy), the only changes should be CHANGELOG updates.
144145
- [ ] Finish updating/merging the [RELEASE_ISSUE_TEMPLATE.md](https://github.com/filecoin-project/lotus/blob/master/documentation/misc/RELEASE_ISSUE_TEMPLATE.md) PR from `Before RC1` with any improvements determined from this latest release iteration.

0 commit comments

Comments
 (0)