-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Labels
P1P1: Must be resolvedP1: Must be resolveddif/easyAn existing lotus user should be able to pick this upAn existing lotus user should be able to pick this upgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededkind/bugKind: BugKind: Bug
Description
The use of go.rice was removed in #6208 to support AppImage, but it was not completely removed and still exists in a few places that needs to be fixed.
➜ lotus git:(master) ag "github.com/GeertJohan/go.rice"
cmd/lotus-townhall/main.go
11: rice "github.com/GeertJohan/go.rice"
cmd/lotus-fountain/main.go
12: rice "github.com/GeertJohan/go.rice"
go.mod
9: github.com/GeertJohan/go.rice v1.0.0
go.sum
39:github.com/GeertJohan/go.rice v1.0.0 h1:KkI6O9uMaQU3VEKaj01ulavtF7o1fWT7+pk/4voiMLQ=
40:github.com/GeertJohan/go.rice v1.0.0/go.mod h1:eH6gbSOAUv07dQuZVnBmoDP8mgsM1rtixis4Tib9if0=
testplans/lotus-soup/go.sum
43:github.com/GeertJohan/go.rice v1.0.0 h1:KkI6O9uMaQU3VEKaj01ulavtF7o1fWT7+pk/4voiMLQ=
44:github.com/GeertJohan/go.rice v1.0.0/go.mod h1:eH6gbSOAUv07dQuZVnBmoDP8mgsM1rtixis4Tib9if0=
build/tools.go
6: _ "github.com/GeertJohan/go.rice/rice"
This is a fresh clone of lotus, I do not believe go.rice should show up anywhere in the source tree.
Metadata
Metadata
Assignees
Labels
P1P1: Must be resolvedP1: Must be resolveddif/easyAn existing lotus user should be able to pick this upAn existing lotus user should be able to pick this upgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededkind/bugKind: BugKind: Bug