Merge pull request #435 from filecoin-project/chore/magik-audit-clueanups

Magik audit clueanups

Author: Stebalien

fvm/src/blockstore/buffered.rs

@@ -9,18 +9,11 @@ use fvm_shared::blockstore::{Blockstore, Buffered};
 // TODO: figure out where to put this.
 const DAG_CBOR: u64 = 0x71;
 
-// NOTE: This code doesn't currently work. It was taken from the ipld/blockstore crate but now lives here because that "blockstore" is really the actor store.
-// TODO:
-// 1. Finish converting it to a true blockstore.
-// 2. Add bulk put methods to the blockstore.
-
 // TODO: replace HashMap with DashMap like in forest?
 use std::cell::RefCell;
 use std::collections::HashMap;
 use std::io::{Cursor, Read, Seek};
 
-// TODO: This is going to live in the kernel so it should be a Blockstore, not an ActorStore.
-
 /// Wrapper around `Blockstore` to limit and have control over when values are written.
 /// This type is not threadsafe and can only be used in synchronous contexts.
 #[derive(Debug)]

fvm/src/call_manager/backtrace.rs

@@ -10,7 +10,7 @@ use crate::kernel::SyscallError;
 /// A call backtrace records _why_ an actor exited with a specific error code.
 #[derive(Debug, Default, Clone)]
 pub struct Backtrace {
-    /// The actors through which this error was propegated from bottom (source) to top.
+    /// The actors through which this error was propagated from bottom (source) to top.
     pub frames: Vec<Frame>,
     /// The last syscall error before the first actor in `frames` aborted.
     pub cause: Option<Cause>,

fvm/src/lib.rs

@@ -45,20 +45,13 @@ lazy_static::lazy_static! {
 pub struct Config {
     /// The maximum call depth.
     pub max_call_depth: u32,
-    /// Initial number of memory pages to allocate for the invocation container.
-    pub initial_pages: usize,
-    /// Maximum number of memory pages an invocation container's memory
-    /// can expand to.
-    pub max_pages: usize,
     /// Whether debug mode is enabled or not.
     pub debug: bool,
 }
 
 impl Default for Config {
     fn default() -> Self {
         Self {
-            initial_pages: 0,
-            max_pages: 1024,
             max_call_depth: 4096,
             debug: false,
         }

rust-toolchain

@@ -1 +1 @@
-stable
+nightly

testing/conformance/src/vm.rs

@@ -75,8 +75,6 @@ impl TestMachine<Box<DefaultMachine<MemoryBlockstore, TestExterns>>> {
         let machine = DefaultMachine::new(
             Config {
                 max_call_depth: 4096,
-                initial_pages: 0,
-                max_pages: 1024,
                 debug: true, // Enable debug mode by default.
             },
             engine,