Resolving PR comments

Author: jottinger

src/main/java/io/github/filelize/Filelizer.java

@@ -45,21 +45,11 @@ private IFilelizer resolveFilelizerType(Object valueType) {
     }
 
     private IFilelizer resolveFilelizerType(FilelizeType filelizeType) {
-        // I do not like this implementation. It's mandated because of object graph structure and Java 11.
-        // With Java 17 or later, this becomes a switch expression and is much nicer.
-        IFilelizer filelizer = null;
-        switch (filelizeType) {
-            case MULTIPLE_FILES:
-                filelizer = filelizerMultiple;
-                break;
-            case SINGLE_FILE:
-                filelizer = filelizerSingle;
-                break;
-            case OBJECT_FILE:
-                filelizer = filelizerObject;
-                break;
-        }
-        return filelizer;
+        return switch(filelizeType) {
+            case MULTIPLE_FILES -> filelizerMultiple;
+            case SINGLE_FILE -> filelizerSingle;
+            case OBJECT_FILE -> filelizerObject;
+        };
     }
 
     @Override

src/main/java/io/github/filelize/path/PathHandler.java

@@ -32,6 +32,7 @@ public String getFullPath2(String id, Object object) {
         return getDirectoryPath(object) + "/" + id + ".json";
     }
 
+    // TODO should use the abstraction from Filelizer to dispatch: object graph issue
     public <T> String getFullPath(String id, Class<T> valueType) {
         if(filelizeType == FilelizeType.MULTIPLE_FILES) {
             var name = getFilelizeName(valueType);

src/test/java/io/github/filelize/path/PathHandlerSingleTest.java

@@ -9,6 +9,7 @@
 import java.util.Map;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 public class PathHandlerSingleTest {
 
@@ -17,7 +18,14 @@ public class PathHandlerSingleTest {
     public PathHandlerSingleTest() {
         this.pathHandler = new PathHandler("src/test/resources", FilelizeType.SINGLE_FILE, new ObjectMapper());
     }
-
+@Test
+public void testPathHandlerReturnsEmptyBaseForNull() {
+        // TODO clarify API visibility
+        assertThrows(NullPointerException.class, () -> {
+            var path = pathHandler.getFullPath2("foo", null);
+            assertEquals("src/test/resources/foo.json", path);
+        });
+}
     @Test
     public void testGetFullPath() {
         var fullPath = pathHandler.getFullPath(new SomethingSingle());