Fix: Fixed create file button when entering text with Chinese input flyout (#11040)

Author: hecksmosis

src/Files.App/Filesystem/FilesystemOperations/Helpers/FilesystemHelpers.cs

@@ -648,7 +648,7 @@ public async Task<ReturnResult> RecycleItemsFromClipboard(DataPackageView packag
 
 		#endregion IFilesystemHelpers
 
-		private static bool IsValidForFilename(string name)
+		public static bool IsValidForFilename(string name)
 			=> !string.IsNullOrWhiteSpace(name) && !ContainsRestrictedCharacters(name) && !ContainsRestrictedFileName(name);
 
 		private static async Task<(List<FileNameConflictResolveOptionType> collisions, bool cancelOperation, IEnumerable<IFileSystemDialogConflictItemViewModel>)> GetCollision(FilesystemOperationType operationType, IEnumerable<IStorageItemWithPath> source, IEnumerable<string> destination, bool forceDialog)

src/Files.App/Helpers/DynamicDialogFactory.cs

@@ -57,50 +57,28 @@ public static DynamicDialog GetFor_ShortcutNotFound(string targetPath)
 
 		public static DynamicDialog GetFor_RenameDialog()
 		{
-			DynamicDialog dialog = null;
-			TextBox inputText = new TextBox()
+			DynamicDialog? dialog = null;
+			TextBox inputText = new()
 			{
 				Height = 35d,
 				PlaceholderText = "RenameDialogInputText/PlaceholderText".GetLocalizedResource()
 			};
 
-			TextBlock tipText = new TextBlock()
+			TextBlock tipText = new()
 			{
-				Text = "RenameDialogSymbolsTip/Text".GetLocalizedResource(),
+				Text = "InvalidFilename/Text".GetLocalizedResource(),
 				Margin = new Microsoft.UI.Xaml.Thickness(0, 0, 4, 0),
 				TextWrapping = Microsoft.UI.Xaml.TextWrapping.Wrap,
 				Opacity = 0.0d
 			};
 
-			inputText.BeforeTextChanging += async (textBox, args) =>
+			inputText.TextChanged += (textBox, args) =>
 			{
-				if (FilesystemHelpers.ContainsRestrictedCharacters(args.NewText))
-				{
-					args.Cancel = true;
-					await inputText.DispatcherQueue.EnqueueAsync(() =>
-					{
-						var oldSelection = textBox.SelectionStart + textBox.SelectionLength;
-						var oldText = textBox.Text;
-						textBox.Text = FilesystemHelpers.FilterRestrictedCharacters(args.NewText);
-						textBox.SelectionStart = oldSelection + textBox.Text.Length - oldText.Length;
-						tipText.Opacity = 1.0d;
-					});
-				}
-				else
-				{
-					dialog.ViewModel.AdditionalData = args.NewText;
-
-					if (!string.IsNullOrWhiteSpace(args.NewText))
-					{
-						dialog.ViewModel.DynamicButtonsEnabled = DynamicDialogButtons.Primary | DynamicDialogButtons.Cancel;
-					}
-					else
-					{
-						dialog.ViewModel.DynamicButtonsEnabled = DynamicDialogButtons.Cancel;
-					}
-
-					tipText.Opacity = 0.0d;
-				}
+				var isInputValid = FilesystemHelpers.IsValidForFilename(inputText.Text);
+				tipText.Opacity = isInputValid ? 0.0d : 1.0d;
+				dialog!.ViewModel.DynamicButtonsEnabled = isInputValid 
+														? DynamicDialogButtons.Primary | DynamicDialogButtons.Cancel
+														: DynamicDialogButtons.Cancel;
 			};
 
 			inputText.Loaded += (s, e) =>

src/Files.App/Strings/en-US/Resources.resw

@@ -513,8 +513,8 @@
   <data name="FileNameTeachingTip.CloseButtonContent" xml:space="preserve">
     <value>OK</value>
   </data>
-  <data name="RenameDialogSymbolsTip.Text" xml:space="preserve">
-    <value>The item name must not contain the following characters: \ / : * ? " &lt; &gt; |</value>
+  <data name="InvalidFilename.Text" xml:space="preserve">
+    <value>The item name specified is invalid</value>
   </data>
   <data name="ItemSelected.Text" xml:space="preserve">
     <value>item selected</value>