Skip to content

Commit 050a7c1

Browse files
authored
Feature: Improved UX for toolbar settings (#16167)
1 parent cad5277 commit 050a7c1

File tree

2 files changed

+33
-22
lines changed

2 files changed

+33
-22
lines changed

src/Files.App/Strings/en-US/Resources.resw

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3152,7 +3152,7 @@
31523152
<value>Mica Alt</value>
31533153
</data>
31543154
<data name="BackdropMaterial" xml:space="preserve">
3155-
<value>Backdrop Material</value>
3155+
<value>Backdrop</value>
31563156
</data>
31573157
<data name="Solid" xml:space="preserve">
31583158
<value>Solid</value>
@@ -3881,8 +3881,8 @@
38813881
<value>Status:</value>
38823882
</data>
38833883
<data name="ShowToolbar" xml:space="preserve">
3884-
<value>Show Toolbar</value>
3885-
<comment>Setting that controls if the Toolbar is shown in the main view</comment>
3884+
<value>Show toolbar</value>
3885+
<comment>Setting that controls if the toolbar is shown in the main view</comment>
38863886
</data>
38873887
<data name="TabActions" xml:space="preserve">
38883888
<value>Tab actions menu</value>
@@ -3939,6 +3939,9 @@
39393939
<value>Navigate to the home page</value>
39403940
</data>
39413941
<data name="ShowHomeButton" xml:space="preserve">
3942-
<value>Show home button in the toolbar</value>
3942+
<value>Show Home in address bar</value>
3943+
</data>
3944+
<data name="Toolbars" xml:space="preserve">
3945+
<value>Toolbars</value>
39433946
</data>
39443947
</root>

src/Files.App/Views/Settings/AppearancePage.xaml

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -250,27 +250,35 @@
250250
Style="{StaticResource RightAlignedToggleSwitchStyle}" />
251251
</local:SettingsBlockControl>
252252

253-
<!-- Show home button -->
254-
<local:SettingsBlockControl Title="{helpers:ResourceString Name=ShowHomeButton}" HorizontalAlignment="Stretch">
255-
<local:SettingsBlockControl.Icon>
256-
<FontIcon Glyph="&#xE80F;" />
257-
</local:SettingsBlockControl.Icon>
258-
<ToggleSwitch
259-
AutomationProperties.AutomationControlType="Custom"
260-
AutomationProperties.Name="{helpers:ResourceString Name=ShowHomeButton}"
261-
IsOn="{x:Bind ViewModel.ShowHomeButton, Mode=TwoWay}"
262-
Style="{StaticResource RightAlignedToggleSwitchStyle}" />
263-
</local:SettingsBlockControl>
264-
265-
<!-- Show toolbar -->
266-
<local:SettingsBlockControl Title="{helpers:ResourceString Name=ShowToolbar}" HorizontalAlignment="Stretch">
253+
<!-- Toolbar -->
254+
<local:SettingsBlockControl
255+
Title="{helpers:ResourceString Name=Toolbars}"
256+
HorizontalAlignment="Stretch"
257+
IsExpanded="False">
267258
<local:SettingsBlockControl.Icon>
268259
<PathIcon Data="{StaticResource App.Theme.PathIcon.WebAsset}" />
269260
</local:SettingsBlockControl.Icon>
270-
<ToggleSwitch
271-
AutomationProperties.Name="{helpers:ResourceString Name=ShowToolbar}"
272-
IsOn="{x:Bind ViewModel.ShowToolbar, Mode=TwoWay}"
273-
Style="{StaticResource RightAlignedToggleSwitchStyle}" />
261+
262+
<local:SettingsBlockControl.ExpandableContent>
263+
<StackPanel>
264+
<!-- Show home button -->
265+
<local:SettingsBlockControl Title="{helpers:ResourceString Name=ShowHomeButton}" HorizontalAlignment="Stretch">
266+
<ToggleSwitch
267+
AutomationProperties.AutomationControlType="Custom"
268+
AutomationProperties.Name="{helpers:ResourceString Name=ShowHomeButton}"
269+
IsOn="{x:Bind ViewModel.ShowHomeButton, Mode=TwoWay}"
270+
Style="{StaticResource RightAlignedToggleSwitchStyle}" />
271+
</local:SettingsBlockControl>
272+
273+
<!-- Show toolbar -->
274+
<local:SettingsBlockControl Title="{helpers:ResourceString Name=ShowToolbar}" HorizontalAlignment="Stretch">
275+
<ToggleSwitch
276+
AutomationProperties.Name="{helpers:ResourceString Name=ShowToolbar}"
277+
IsOn="{x:Bind ViewModel.ShowToolbar, Mode=TwoWay}"
278+
Style="{StaticResource RightAlignedToggleSwitchStyle}" />
279+
</local:SettingsBlockControl>
280+
</StackPanel>
281+
</local:SettingsBlockControl.ExpandableContent>
274282
</local:SettingsBlockControl>
275283
</StackPanel>
276284
</Grid>

0 commit comments

Comments
 (0)