Added Test button

Author: ferrariofilippo

src/Files.App/Strings/en-US/Resources.resw

@@ -4049,4 +4049,10 @@
   <data name="PathOrAlias" xml:space="preserve">
     <value>Path or alias</value>
   </data>
+  <data name="InvalidPath" xml:space="preserve">
+    <value>Invalid path</value>
+  </data>
+  <data name="Test" xml:space="preserve">
+    <value>Test</value>
+  </data>
 </root>

src/Files.App/ViewModels/Settings/DevToolsViewModel.cs

@@ -18,6 +18,7 @@ public sealed partial class DevToolsViewModel : ObservableObject
 		public ICommand CancelIDEChangesCommand { get; }
 		public ICommand SaveIDEChangesCommand { get; }
 		public ICommand OpenFilePickerForIDECommand { get; }
+		public ICommand TestIDECommand { get; }
 
 		// Enabled when there are saved credentials
 		private bool _IsLogoutEnabled;
@@ -34,18 +35,21 @@ public bool IsEditingIDEConfig
 			set => SetProperty(ref _IsEditingIDEConfig, value);
 		}
 
-		private bool _CanSaveIDEChanges;
-		public bool CanSaveIDEChanges
+		public bool CanSaveIDEChanges =>
+			IsFriendlyNameValid && IsIDEPathValid && _IDEPathTested;
+
+		private bool _IsIDEPathValid;
+		public bool IsIDEPathValid
 		{
-			get => _CanSaveIDEChanges;
-			set => SetProperty(ref _CanSaveIDEChanges, value);
+			get => _IsIDEPathValid;
+			set => SetProperty(ref _IsIDEPathValid, value);
 		}
 
 		private bool _IsFriendlyNameValid;
 		public bool IsFriendlyNameValid
 		{
-			get => _IsFriendlyNameValid;
-			set => SetProperty(ref _IsFriendlyNameValid, value);
+			get => _IsIDEPathValid;
+			set => SetProperty(ref _IsIDEPathValid, value);
 		}
 
 		private string _IDEPath;
@@ -55,7 +59,13 @@ public string IDEPath
 			set
 			{
 				if (SetProperty(ref _IDEPath, value))
-					CanSaveIDEChanges = IsFriendlyNameValid && !string.IsNullOrWhiteSpace(IDEPath);
+				{
+					IsIDEPathValid =
+						!string.IsNullOrWhiteSpace(value) &&
+						!value.Contains('\"') &&
+						!value.Contains('\'');
+					IDEPathTested = false;
+				}
 			}
 		}
 
@@ -67,15 +77,23 @@ public string IDEFriendlyName
 			{
 				if (SetProperty(ref _IDEFriendlyName, value))
 				{
-					IsFriendlyNameValid =
-						!string.IsNullOrEmpty(value) &&
-						!value.Contains('\"') &&
-						!value.Contains('\'');
-					CanSaveIDEChanges = IsFriendlyNameValid && !string.IsNullOrWhiteSpace(IDEPath);
+					IsFriendlyNameValid = !string.IsNullOrEmpty(value);
+					OnPropertyChanged(nameof(CanSaveIDEChanges));
 				}
 			}
 		}
 
+		private bool _IDEPathTested = false;
+		public bool IDEPathTested
+		{
+			get => _IDEPathTested;
+			set
+			{
+				if (SetProperty(ref _IDEPathTested, value))
+					OnPropertyChanged(nameof(CanSaveIDEChanges));
+			}
+		}
+
 		public DevToolsViewModel()
 		{
 			// Open in IDE options
@@ -85,8 +103,8 @@ public DevToolsViewModel()
 
 			IDEPath = DevToolsSettingsService.IDEPath;
 			IDEFriendlyName = DevToolsSettingsService.FriendlyIDEName;
+			IsIDEPathValid = true;
 			IsFriendlyNameValid = true;
-			CanSaveIDEChanges = false;
 
 			IsLogoutEnabled = GitHelpers.GetSavedCredentials() != string.Empty;
 
@@ -96,6 +114,7 @@ public DevToolsViewModel()
 			SaveIDEChangesCommand = new RelayCommand(DoSaveIDEChanges);
 			StartEditingIDECommand = new RelayCommand(DoStartEditingIDE);
 			OpenFilePickerForIDECommand = new RelayCommand(DoOpenFilePickerForIDE);
+			TestIDECommand = new RelayCommand(DoTestIDE);
 		}
 
 		private string selectedOpenInIDEOption;
@@ -131,13 +150,15 @@ private void DoCancelIDEChanges()
 			IsEditingIDEConfig = false;
 			IDEPath = DevToolsSettingsService.IDEPath;
 			IDEFriendlyName = DevToolsSettingsService.FriendlyIDEName;
+			IsIDEPathValid = true;
+			IsFriendlyNameValid = true;
 		}
 
 		private void DoSaveIDEChanges()
 		{
 			IsEditingIDEConfig = false;
+			IsIDEPathValid = true;
 			IsFriendlyNameValid = true;
-			CanSaveIDEChanges = false;
 			DevToolsSettingsService.IDEPath = IDEPath;
 			DevToolsSettingsService.FriendlyIDEName = IDEFriendlyName;
 		}
@@ -149,15 +170,25 @@ private void DoStartEditingIDE()
 
 		private void DoOpenFilePickerForIDE()
 		{
-			var result = CommonDialogService.Open_FileOpenDialog(
+			CommonDialogService.Open_FileOpenDialog(
 				MainWindow.Instance.WindowHandle,
 				false,
-				[ "*.exe;*.bat;*.cmd;*.ahk" ],
+				["*.exe;*.bat;*.cmd;*.ahk"],
 				Environment.SpecialFolder.ProgramFiles,
 				out var filePath
 			);
 
 			IDEPath = filePath;
 		}
+
+		private async void DoTestIDE()
+		{
+			IDEPathTested = await Win32Helper.RunPowershellCommandAsync(
+				$"& \'{IDEPath}\'",
+				PowerShellExecutionOptions.None // PowerShellExecutionOptions.Hidden doesn't work with some IDEs if path is not provided
+			);
+
+			IsIDEPathValid = _IDEPathTested;
+		}
 	}
 }

src/Files.App/Views/Settings/DevToolsPage.xaml

@@ -109,8 +109,49 @@
 									x:Name="PickIDEExe"
 									Command="{x:Bind ViewModel.OpenFilePickerForIDECommand, Mode=OneWay}"
 									Content="{helpers:ResourceString Name=Browse}" />
+								<Button
+									x:Name="TestIDE"
+									Command="{x:Bind ViewModel.TestIDECommand, Mode=OneWay}"
+									Content="{helpers:ResourceString Name=Test}"
+									IsEnabled="{x:Bind ViewModel.IDEPathTested, Converter={StaticResource BoolNegationConverter}, Mode=OneWay}" />
 							</StackPanel>
 
+							<Grid
+								x:Name="InvalidPathWarning"
+								Grid.Column="2"
+								Padding="12,4"
+								VerticalAlignment="Stretch"
+								x:Load="{x:Bind ViewModel.IsEditingIDEConfig, Mode=OneWay}"
+								Background="{ThemeResource SystemFillColorCriticalBackgroundBrush}"
+								BorderBrush="{ThemeResource CardStrokeColorDefaultBrush}"
+								BorderThickness="1"
+								ColumnSpacing="8"
+								CornerRadius="4"
+								ToolTipService.ToolTip="{helpers:ResourceString Name=InvalidLocation}"
+								Visibility="{x:Bind ViewModel.IsIDEPathValid, Mode=OneWay, Converter={StaticResource InvertedBoolVisibilityConverter}}">
+								<Grid.ColumnDefinitions>
+									<ColumnDefinition Width="Auto" />
+									<ColumnDefinition Width="Auto" />
+								</Grid.ColumnDefinitions>
+								<TextBlock
+									VerticalAlignment="Center"
+									AutomationProperties.AccessibilityView="Raw"
+									FontFamily="{ThemeResource SymbolThemeFontFamily}"
+									FontSize="{StaticResource InfoBarIconFontSize}"
+									Foreground="{ThemeResource InfoBarErrorSeverityIconBackground}"
+									Text="{StaticResource InfoBarIconBackgroundGlyph}" />
+								<TextBlock
+									VerticalAlignment="Center"
+									FontFamily="{ThemeResource SymbolThemeFontFamily}"
+									FontSize="{StaticResource InfoBarIconFontSize}"
+									Foreground="{ThemeResource InfoBarInformationalSeverityIconForeground}"
+									Text="{StaticResource InfoBarErrorIconGlyph}" />
+								<TextBlock
+									Grid.Column="1"
+									VerticalAlignment="Center"
+									Text="{helpers:ResourceString Name=InvalidPath}" />
+							</Grid>
+
 							<TextBlock
 								x:Name="IDEFriendlyName"
 								Grid.Row="1"