Code Quality: Avoid unnecessary shell folder fetching (#15140)

Author: hishitetsu

src/Files.App/Helpers/Win32/Win32Helper.Shell.cs

@@ -17,7 +17,7 @@ public static partial class Win32Helper
 
 		private readonly static ShellFolder _controlPanelCategoryView = new("::{26EE0668-A00A-44D7-9371-BEB064C98683}");
 
-		public static async Task<(ShellFileItem Folder, List<ShellFileItem> Enumerate)> GetShellFolderAsync(string path, string action, int from, int count, params string[] properties)
+		public static async Task<(ShellFileItem Folder, List<ShellFileItem> Enumerate)> GetShellFolderAsync(string path, bool getFolder, bool getEnumerate, int from, int count, params string[] properties)
 		{
 			if (path.StartsWith("::{", StringComparison.Ordinal))
 			{
@@ -43,9 +43,10 @@ public static partial class Win32Helper
 						return (null, flc);
 					}
 
-					folder = ShellFolderExtensions.GetShellFileItem(shellFolder);
+					if (getFolder)
+						folder = ShellFolderExtensions.GetShellFileItem(shellFolder);
 
-					if (action == "Enumerate")
+					if (getEnumerate)
 					{
 						foreach (var folderItem in shellFolder.Skip(from).Take(count))
 						{

src/Files.App/Services/QuickAccessService.cs

@@ -12,7 +12,7 @@ internal sealed class QuickAccessService : IQuickAccessService
 
 		public async Task<IEnumerable<ShellFileItem>> GetPinnedFoldersAsync()
 		{
-			var result = (await Win32Helper.GetShellFolderAsync(guid, "Enumerate", 0, int.MaxValue, "System.Home.IsPinned")).Enumerate
+			var result = (await Win32Helper.GetShellFolderAsync(guid, false, true, 0, int.MaxValue, "System.Home.IsPinned")).Enumerate
 				.Where(link => link.IsFolder);
 			return result;
 		}

src/Files.App/Utils/RecentItem/RecentItems.cs

@@ -109,7 +109,7 @@ public async Task UpdateRecentFoldersAsync()
 		/// </summary>
 		public async Task<List<RecentItem>> ListRecentFilesAsync()
 		{
-			return (await Win32Helper.GetShellFolderAsync(QuickAccessGuid, "Enumerate", 0, int.MaxValue)).Enumerate
+			return (await Win32Helper.GetShellFolderAsync(QuickAccessGuid, false, true, 0, int.MaxValue)).Enumerate
 				.Where(link => !link.IsFolder)
 				.Select(link => new RecentItem(link, ShowFileExtensions)).ToList();
 		}

src/Files.App/Utils/RecycleBin/RecycleBinHelpers.cs

@@ -19,7 +19,7 @@ public static class RecycleBinHelpers
 
 		public static async Task<List<ShellFileItem>> EnumerateRecycleBin()
 		{
-			return (await Win32Helper.GetShellFolderAsync(Constants.UserEnvironmentPaths.RecycleBinPath, "Enumerate", 0, int.MaxValue)).Enumerate;
+			return (await Win32Helper.GetShellFolderAsync(Constants.UserEnvironmentPaths.RecycleBinPath, false, true, 0, int.MaxValue)).Enumerate;
 		}
 
 		public static ulong GetSize()

src/Files.App/Utils/Storage/StorageItems/ShellStorageFolder.cs

@@ -108,7 +108,7 @@ public static IAsyncOperation<BaseStorageFolder> FromPathAsync(string path)
 
 		protected static async Task<(ShellFileItem Folder, List<ShellFileItem> Items)> GetFolderAndItems(string path, bool enumerate, int startIndex = 0, int maxItemsToRetrieve = int.MaxValue)
 		{
-			return await Win32Helper.GetShellFolderAsync(path, enumerate ? "Enumerate" : "Query", startIndex, maxItemsToRetrieve);
+			return await Win32Helper.GetShellFolderAsync(path, !enumerate, enumerate, startIndex, maxItemsToRetrieve);
 		}
 
 		public override IAsyncOperation<StorageFolder> ToStorageFolderAsync() => throw new NotSupportedException();