Feature: Added an option to hide 'Open in Terminal' from the context menu (#17349)

yaira2 · web-flow · commit 10de56c7831f · 2025-07-29T11:39:43.000-04:00
diff --git a/src/Files.App/Data/Contracts/IGeneralSettingsService.cs b/src/Files.App/Data/Contracts/IGeneralSettingsService.cs
@@ -215,6 +215,11 @@ public interface IGeneralSettingsService : IBaseSettingsService, INotifyProperty
 		/// </summary>
 		bool ShowOpenInNewPane { get; set; }
 
+		/// <summary>
+		/// Gets or sets a value indicating whether or not to show the option to open folders in Windows Terminal.
+		/// </summary>
+		bool ShowOpenTerminal { get; set; }
+
 		/// <summary>
 		/// Gets or sets a value indicating whether or not to show the option to copy an items path.
 		/// </summary>
diff --git a/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs b/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs
@@ -612,14 +612,16 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 				new ContextMenuFlyoutItemViewModel()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
-					ShowItem = (!itemsSelected && Commands.OpenTerminal.IsExecutable) ||
-						(areAllItemsFolders && Commands.OpenTerminal.IsExecutable) ||
+					ShowItem = (!itemsSelected && Commands.OpenTerminal.IsExecutable && UserSettingsService.GeneralSettingsService.ShowOpenTerminal) ||
+						(areAllItemsFolders && Commands.OpenTerminal.IsExecutable && UserSettingsService.GeneralSettingsService.ShowOpenTerminal) ||
 						Commands.OpenStorageSense.IsExecutable ||
 						Commands.FormatDrive.IsExecutable
 				},
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenTerminal)
 				{
-					IsVisible = (!itemsSelected && Commands.OpenTerminal.IsExecutable) || (areAllItemsFolders && Commands.OpenTerminal.IsExecutable)
+					IsVisible = (!itemsSelected || areAllItemsFolders) &&
+						Commands.OpenTerminal.IsExecutable &&
+						UserSettingsService.GeneralSettingsService.ShowOpenTerminal
 				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenStorageSense).Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.FormatDrive).Build(),
diff --git a/src/Files.App/Services/Settings/GeneralSettingsService.cs b/src/Files.App/Services/Settings/GeneralSettingsService.cs
@@ -281,6 +281,12 @@ public bool ShowOpenInNewPane
 			set => Set(value);
 		}
 
+		public bool ShowOpenTerminal
+		{
+			get => Get(true);
+			set => Set(value);
+		}
+
 		public bool ShowCopyPath
 		{
 			get => Get(true);
diff --git a/src/Files.App/Strings/en-US/Resources.resw b/src/Files.App/Strings/en-US/Resources.resw
@@ -4273,4 +4273,7 @@
   <data name="Filename" xml:space="preserve">
     <value>Filename</value>
   </data>
+  <data name="ShowOpenTerminal" xml:space="preserve">
+    <value>Show option to open folders in Windows Terminal</value>
+  </data>
 </root>
diff --git a/src/Files.App/ViewModels/Settings/GeneralViewModel.cs b/src/Files.App/ViewModels/Settings/GeneralViewModel.cs
@@ -521,6 +521,19 @@ public bool ShowOpenInNewWindow
 			}
 		}
 
+		public bool ShowOpenTerminal
+		{
+			get => UserSettingsService.GeneralSettingsService.ShowOpenTerminal;
+			set
+			{
+				if (value != UserSettingsService.GeneralSettingsService.ShowOpenTerminal)
+				{
+					UserSettingsService.GeneralSettingsService.ShowOpenTerminal = value;
+					OnPropertyChanged();
+				}
+			}
+		}
+
 		private string selectedShellPaneArrangementType;
 		public string SelectedShellPaneArrangementType
 		{
diff --git a/src/Files.App/ViewModels/UserControls/SidebarViewModel.cs b/src/Files.App/ViewModels/UserControls/SidebarViewModel.cs
@@ -1043,11 +1043,14 @@ private List<ContextMenuFlyoutItemViewModel> GetLocationItemMenuItems(INavigatio
 				new ContextMenuFlyoutItemViewModel()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
-					ShowItem = Commands.OpenTerminalFromSidebar.IsExecutable ||
+					ShowItem = (UserSettingsService.GeneralSettingsService.ShowOpenTerminal && Commands.OpenTerminalFromSidebar.IsExecutable) ||
 						Commands.OpenStorageSenseFromSidebar.IsExecutable ||
 						Commands.FormatDriveFromSidebar.IsExecutable
 				},
-				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenTerminalFromSidebar).Build(),
+				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenTerminalFromSidebar)
+				{
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenTerminal && Commands.OpenTerminalFromSidebar.IsExecutable
+				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenStorageSenseFromSidebar).Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.FormatDriveFromSidebar).Build(),
 				new ContextMenuFlyoutItemViewModel()
diff --git a/src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs b/src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs
@@ -153,11 +153,14 @@ public override List<ContextMenuFlyoutItemViewModel> GetItemMenuItems(WidgetCard
 				new ContextMenuFlyoutItemViewModel()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
-					ShowItem = CommandManager.OpenTerminalFromHome.IsExecutable ||
+					ShowItem = (UserSettingsService.GeneralSettingsService.ShowOpenTerminal && CommandManager.OpenTerminalFromHome.IsExecutable) ||
 						CommandManager.OpenStorageSenseFromHome.IsExecutable ||
 						CommandManager.FormatDriveFromHome.IsExecutable
 				},
-				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenTerminalFromHome).Build(),
+				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenTerminalFromHome)
+				{
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenTerminal && CommandManager.OpenTerminalFromHome.IsExecutable
+				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenStorageSenseFromHome).Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.FormatDriveFromHome).Build(),
 				new()
diff --git a/src/Files.App/ViewModels/UserControls/Widgets/FileTagsWidgetViewModel.cs b/src/Files.App/ViewModels/UserControls/Widgets/FileTagsWidgetViewModel.cs
@@ -154,9 +154,12 @@ public override List<ContextMenuFlyoutItemViewModel> GetItemMenuItems(WidgetCard
 				new ContextMenuFlyoutItemViewModel()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
-					ShowItem = CommandManager.OpenTerminalFromHome.IsExecutable
+					ShowItem = UserSettingsService.GeneralSettingsService.ShowOpenTerminal && CommandManager.OpenTerminalFromHome.IsExecutable,
 				},
-				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenTerminalFromHome).Build(),
+				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenTerminalFromHome)
+				{
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenTerminal && CommandManager.OpenTerminalFromHome.IsExecutable
+				}.Build(),
 				new()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
diff --git a/src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs b/src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs
@@ -136,9 +136,12 @@ public override List<ContextMenuFlyoutItemViewModel> GetItemMenuItems(WidgetCard
 				new ContextMenuFlyoutItemViewModel()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
-					ShowItem = CommandManager.OpenTerminalFromHome.IsExecutable
+					ShowItem = UserSettingsService.GeneralSettingsService.ShowOpenTerminal && CommandManager.OpenTerminalFromHome.IsExecutable
 				},
-				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenTerminalFromHome).Build(),
+				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenTerminalFromHome)
+				{
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenTerminal && CommandManager.OpenTerminalFromHome.IsExecutable
+				}.Build(),
 				new()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
diff --git a/src/Files.App/Views/Settings/GeneralPage.xaml b/src/Files.App/Views/Settings/GeneralPage.xaml
@@ -300,6 +300,11 @@
 						<ToggleSwitch AutomationProperties.Name="{helpers:ResourceString Name=ShowSendToMenu}" IsOn="{x:Bind ViewModel.ShowSendToMenu, Mode=TwoWay}" />
 					</wctcontrols:SettingsCard>
 
+					<!--  Open in Windows Terminal  -->
+					<wctcontrols:SettingsCard Header="{helpers:ResourceString Name=ShowOpenTerminal}">
+						<ToggleSwitch AutomationProperties.Name="{helpers:ResourceString Name=ShowOpenTerminal}" IsOn="{x:Bind ViewModel.ShowOpenTerminal, Mode=TwoWay}" />
+					</wctcontrols:SettingsCard>
+
 					<!--  Edit tags  -->
 					<wctcontrols:SettingsCard Header="{helpers:ResourceString Name=ShowEditTagsMenu}">
 						<ToggleSwitch AutomationProperties.Name="{helpers:ResourceString Name=ShowEditTagsMenu}" IsOn="{x:Bind ViewModel.ShowEditTagsMenu, Mode=TwoWay}" />

Original file line number	Diff line number	Diff line change
`@@ -281,6 +281,12 @@ public bool ShowOpenInNewPane`
`281`	`281`	`set => Set(value);`
`282`	`282`	`}`
`283`	`283`
	`284`	`+ public bool ShowOpenTerminal`
	`285`	`+ {`
	`286`	`+ get => Get(true);`
	`287`	`+ set => Set(value);`
	`288`	`+ }`
	`289`	`+`
`284`	`290`	`public bool ShowCopyPath`
`285`	`291`	`{`
`286`	`292`	`get => Get(true);`
Original file line number	Diff line number	Diff line change
`@@ -521,6 +521,19 @@ public bool ShowOpenInNewWindow`
`521`	`521`	`}`
`522`	`522`	`}`
`523`	`523`
	`524`	`+ public bool ShowOpenTerminal`
	`525`	`+ {`
	`526`	`+ get => UserSettingsService.GeneralSettingsService.ShowOpenTerminal;`
	`527`	`+ set`
	`528`	`+ {`
	`529`	`+ if (value != UserSettingsService.GeneralSettingsService.ShowOpenTerminal)`
	`530`	`+ {`
	`531`	`+ UserSettingsService.GeneralSettingsService.ShowOpenTerminal = value;`
	`532`	`+ OnPropertyChanged();`
	`533`	`+ }`
	`534`	`+ }`
	`535`	`+ }`
	`536`	`+`
`524`	`537`	`private string selectedShellPaneArrangementType;`
`525`	`538`	`public string SelectedShellPaneArrangementType`
`526`	`539`	`{`