Fix: Hidden inappropriate context menu items for Recycle Bin.

workbysaran · workbysaran · commit 11d6a1731440 · 2025-10-30T11:42:17.000+05:30
diff --git a/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs b/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs
@@ -380,7 +380,10 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 				{
 					IsVisible = currentInstanceViewModel.IsPageTypeRecycleBin && itemsSelected,
 				}.Build(),
-				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenItem).Build(),
+				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenItem)
+				{
+					IsVisible = !areAllItemsFolders
+				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenItemWithApplicationPicker)
 				{
 					Tag = "OpenWith",
@@ -409,15 +412,15 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenFileLocation).Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenInNewTab)
 				{
-					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewTab && Commands.OpenInNewTab.IsExecutable
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewTab && Commands.OpenInNewTab.IsExecutable && !currentInstanceViewModel.IsPageTypeRecycleBin
 				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenInNewWindow)
 				{
-					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewWindow && Commands.OpenInNewWindow.IsExecutable
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewWindow && Commands.OpenInNewWindow.IsExecutable && !currentInstanceViewModel.IsPageTypeRecycleBin
 				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenInNewPane)
 				{
-					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewPane && Commands.OpenInNewPane.IsExecutable
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewPane && Commands.OpenInNewPane.IsExecutable && !currentInstanceViewModel.IsPageTypeRecycleBin
 				}.Build(),
 				new ContextMenuFlyoutItemViewModel()
 				{
@@ -479,7 +482,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.CreateFolderWithSelection)
 				{
-					IsVisible = UserSettingsService.GeneralSettingsService.ShowCreateFolderWithSelection && itemsSelected
+					IsVisible = UserSettingsService.GeneralSettingsService.ShowCreateFolderWithSelection && itemsSelected && !currentInstanceViewModel.IsPageTypeRecycleBin
 				}.Build(),
 				new ContextMenuFlyoutItemViewModelBuilder(Commands.CreateShortcut)
 				{

Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,10 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(`
`380`	`380`	`{`
`381`	`381`	`IsVisible = currentInstanceViewModel.IsPageTypeRecycleBin && itemsSelected,`
`382`	`382`	`}.Build(),`
`383`		`- new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenItem).Build(),`
	`383`	`+ new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenItem)`
	`384`	`+ {`
	`385`	`+ IsVisible = !areAllItemsFolders`
	`386`	`+ }.Build(),`
`384`	`387`	`new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenItemWithApplicationPicker)`
`385`	`388`	`{`
`386`	`389`	`Tag = "OpenWith",`
`@@ -409,15 +412,15 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(`
`409`	`412`	`new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenFileLocation).Build(),`
`410`	`413`	`new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenInNewTab)`
`411`	`414`	`{`
`412`		`- IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewTab && Commands.OpenInNewTab.IsExecutable`
	`415`	`+ IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewTab && Commands.OpenInNewTab.IsExecutable && !currentInstanceViewModel.IsPageTypeRecycleBin`
`413`	`416`	`}.Build(),`
`414`	`417`	`new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenInNewWindow)`
`415`	`418`	`{`
`416`		`- IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewWindow && Commands.OpenInNewWindow.IsExecutable`
	`419`	`+ IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewWindow && Commands.OpenInNewWindow.IsExecutable && !currentInstanceViewModel.IsPageTypeRecycleBin`
`417`	`420`	`}.Build(),`
`418`	`421`	`new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenInNewPane)`
`419`	`422`	`{`
`420`		`- IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewPane && Commands.OpenInNewPane.IsExecutable`
	`423`	`+ IsVisible = UserSettingsService.GeneralSettingsService.ShowOpenInNewPane && Commands.OpenInNewPane.IsExecutable && !currentInstanceViewModel.IsPageTypeRecycleBin`
`421`	`424`	`}.Build(),`
`422`	`425`	`new ContextMenuFlyoutItemViewModel()`
`423`	`426`	`{`
`@@ -479,7 +482,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(`
`479`	`482`	`}.Build(),`
`480`	`483`	`new ContextMenuFlyoutItemViewModelBuilder(Commands.CreateFolderWithSelection)`
`481`	`484`	`{`
`482`		`- IsVisible = UserSettingsService.GeneralSettingsService.ShowCreateFolderWithSelection && itemsSelected`
	`485`	`+ IsVisible = UserSettingsService.GeneralSettingsService.ShowCreateFolderWithSelection && itemsSelected && !currentInstanceViewModel.IsPageTypeRecycleBin`
`483`	`486`	`}.Build(),`
`484`	`487`	`new ContextMenuFlyoutItemViewModelBuilder(Commands.CreateShortcut)`
`485`	`488`	`{`