Skip to content

Commit 1695dcf

Browse files
authored
Fix issue where terminal.json has been overwritten on every app launch (#1141)
1 parent 1c60f0c commit 1695dcf

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

Files/DataModels/TerminalFileModel.cs

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,19 @@ public async Task<bool> AddOrRemoveTerminal(TerminalModel terminal, string packa
5050
}
5151
else if (!isInstalled)
5252
{
53-
if (string.IsNullOrWhiteSpace(DefaultTerminalPath))
53+
if (Terminals.Remove(Terminals.FirstOrDefault(x => x.Path.Equals(terminal.Path, StringComparison.OrdinalIgnoreCase))))
5454
{
55-
ResetToDefaultTerminal();
56-
}
57-
else if (DefaultTerminalPath.Equals(terminal.Path, StringComparison.OrdinalIgnoreCase))
58-
{
59-
ResetToDefaultTerminal();
60-
}
61-
Terminals.Remove(Terminals.FirstOrDefault(x => x.Path.Equals(terminal.Path, StringComparison.OrdinalIgnoreCase)));
55+
if (string.IsNullOrWhiteSpace(DefaultTerminalPath))
56+
{
57+
ResetToDefaultTerminal();
58+
}
59+
else if (DefaultTerminalPath.Equals(terminal.Path, StringComparison.OrdinalIgnoreCase))
60+
{
61+
ResetToDefaultTerminal();
62+
}
6263

63-
isChanged = true;
64+
isChanged = true;
65+
}
6466
}
6567
return isChanged;
6668
}

0 commit comments

Comments
 (0)