Do not use symbol classes

Author: 0x5bfa

src/Files.Core.SourceGenerator/Data/ParameterTypeNamePair.cs

@@ -0,0 +1,8 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Files.Core.SourceGenerator.Data
+{
+	internal record ParameterTypeNamePair(string FullyQualifiedTypeName, string ValueName);
+}

src/Files.Core.SourceGenerator/Data/VTableFunctionInfo.cs

@@ -10,5 +10,5 @@ internal record VTableFunctionInfo(
 		string Name,
 		string ReturnTypeName,
 		int Index,
-		EquatableArray<ISymbol> Parameters);
+		EquatableArray<ParameterTypeNamePair> Parameters);
 }

src/Files.Core.SourceGenerator/Generators/VTableFunctionGenerator.cs

@@ -1,9 +1,6 @@
 // Copyright (c) Files Community
 // Licensed under the MIT License.
 
-using Microsoft.CodeAnalysis;
-using System.Reflection;
-
 namespace Files.Core.SourceGenerator.Generators
 {
 	[Generator(LanguageNames.CSharp)]
@@ -41,32 +38,32 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
 					var methodSymbol = (IMethodSymbol)context.TargetSymbol;
 					var functionName = methodSymbol.Name;
 					var returnTypeName = methodSymbol.ReturnType.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat);
-					var parameters = methodSymbol.Parameters.CastArray<ISymbol>();
+					var parameters = methodSymbol.Parameters.Select(x => new ParameterTypeNamePair(x.Type.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat), x.Name));
 					var index = (int)context.Attributes[0].NamedArguments.FirstOrDefault(x => x.Key.Equals("Index")).Value.Value!;
 
-					return new VTableFunctionInfo(fullyQualifiedParentTypeName, structNamespace, structName, functionName, returnTypeName, index, new(parameters));
+					return new VTableFunctionInfo(fullyQualifiedParentTypeName, structNamespace, structName, functionName, returnTypeName, index, new(parameters.ToImmutableArray()));
 				})
 				.Where(static item => item is not null)
 				.Collect()
 				.Select((items, token) =>
 				{
 					token.ThrowIfCancellationRequested();
 
-					return items.GroupBy(source => source.FullyQualifiedParentTypeName, StringComparer.OrdinalIgnoreCase);
+					return items.GroupBy(source => source.FullyQualifiedParentTypeName, StringComparer.OrdinalIgnoreCase).ToImmutableArray();
 				});
 
 
 			context.RegisterSourceOutput(sources, (context, sources) =>
 			{
 				foreach (var source in sources)
 				{
-					string vtableFunctionsCode = GenerateVtableFunctionsForStruct(source);
+					string vtableFunctionsCode = GenerateVtableFunctionsForStruct(source.ToImmutableArray());
 					context.AddSource($"{source.Key}_VTableFunctions.g.cs", vtableFunctionsCode);
 				}
 			});
 		}
 
-		private string GenerateVtableFunctionsForStruct(IEnumerable<VTableFunctionInfo> sources)
+		private string GenerateVtableFunctionsForStruct(ImmutableArray<VTableFunctionInfo> sources)
 		{
 			StringBuilder builder = new();
 
@@ -91,14 +88,12 @@ private string GenerateVtableFunctionsForStruct(IEnumerable<VTableFunctionInfo>
 
 			foreach (var source in sources)
 			{
-				var parameters = source.Parameters.Cast<IParameterSymbol>().ToDictionary(x => x.Type.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat), x => x.Name);
-
 				builder.AppendLine($"	[global::System.Runtime.CompilerServices.MethodImpl(global::System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]");
 
-				builder.AppendLine($"	public partial {source.ReturnTypeName} {source.Name}({string.Join(", ", parameters.Select(x => $"{x.Key} {x.Value}"))})");
+				builder.AppendLine($"	public partial {source.ReturnTypeName} {source.Name}({string.Join(", ", source.Parameters.Select(x => $"{x.FullyQualifiedTypeName} {x.ValueName}"))})");
 				builder.AppendLine($"	{{");
-				builder.AppendLine($"		return ({source.ReturnTypeName})((delegate* unmanaged[MemberFunction]<{sources.ElementAt(0).ParentTypeName}*, {string.Join(", ", parameters.Select(x => $"{x.Key}"))}, int>)(lpVtbl[{source.Index}]))");
-				builder.AppendLine($"			(({sources.ElementAt(0).ParentTypeName}*)global::System.Runtime.CompilerServices.Unsafe.AsPointer(ref this), {string.Join(", ", parameters.Select(x => $"{x.Value}"))});");
+				builder.AppendLine($"		return ({source.ReturnTypeName})((delegate* unmanaged[MemberFunction]<{sources.ElementAt(0).ParentTypeName}*, {string.Join(", ", source.Parameters.Select(x => $"{x.FullyQualifiedTypeName}"))}, int>)(lpVtbl[{source.Index}]))");
+				builder.AppendLine($"			(({sources.ElementAt(0).ParentTypeName}*)global::System.Runtime.CompilerServices.Unsafe.AsPointer(ref this), {string.Join(", ", source.Parameters.Select(x => $"{x.ValueName}"))});");
 				builder.AppendLine($"	}}");
 
 				if (sourceIndex < sourceCount - 1)